Add IAST Security Control tests for java springboot #3576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add Iast security controls system tests for Milestone 0 (RFC)
Changes
New test_security_controls.py that covers all the RFC test cases
Only covers java springboot weblog variant
As it is currently implemented, the new scenario
IAST_SECURITY_CONTROLS
will only work for Java since these tests have the particularity that theDD_IAST_SECURITY_CONTROLS_CONFIGURATION
variable will differ for each tracer, as it represents the configuration of the security controls. For instance, in Java, a possible value could be:INPUT_VALIDATOR:COMMAND_INJECTION:bar.foo.CustomInputValidator:validate
,whereas for Node.js it might be:
INPUT_VALIDATOR:COMMAND_INJECTION:bar/foo/custom_input_validator.js:validate
.Therefore, this is something that would need to be adjusted when other languages implement these tests, or alternatively, this PR could be modified to prepare it to support configurations based on the specific language.
Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present