-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test scenario for DJM with java lib injection #3500
Open
yiliangzhou
wants to merge
22
commits into
main
Choose a base branch
from
liangzhou.yi/djm-with-ssi-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ection tests on djm's web-log variant.
…pp web-log variant, allowing it launching spark application inside k8s
robertomonteromiguel
requested changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to fix the lint failures to test the PR. Use the ./format.sh
command
lib-injection/build/docker/java/dd-djm-spark-test-app/launch.sh
Outdated
Show resolved
Hide resolved
… ensure the tested spark application can use the lib under test.
yiliangzhou
added
the
build-lib-injection-app-images
Build and push weblog images for lib-injection
label
Nov 26, 2024
robertomonteromiguel
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Data Jobs Monitoring (DJM) use Single Step Instrumentation to inject Java tracer to Spark application launched in k8s. The newly added test scenario
K8S_LIBRARY_INJECTION_DJM
allow us to verify the k8s injection continue to work for Data Jobs Monitoring as new Java tracer, new auto_inject, and new cluster_agent are being released.Changes
dd-djm-spark-test-app
, to launch a sample spark application in k8s with DJM related setting (e.x tracer config to enable Spark integration, Spark driver pod annotation to inject java tracer)K8S_LIBRARY_INJECTION_DJM
to test spark application in k8s with DJM enabled. The single test case verifyspark.application
trace are received from the instrumented sample Spark application launched by newly added Java weblog variant (the test case is illustrated roughly as below).K8S_LIBRARY_INJECTION_DJM
test scenario ink8s-lib-injection-tests
.dd-djm-spark-test-app
weblog variant for other irrelevant tests.Workflow
codeowners
file quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>]
, double-check that only<language>
is impacted by the changebuild-XXX-image
label is present