Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add listener ID tag to UDS-specific metrics in DogStatsD source. #364

Closed
tobz opened this issue Dec 2, 2024 · 1 comment
Closed

Add listener ID tag to UDS-specific metrics in DogStatsD source. #364

tobz opened this issue Dec 2, 2024 · 1 comment
Labels
area/components Sources, transforms, and destinations. area/observability Internal observability of ADP and Saluki. effort/simple Involves trivial changes that should be fine so long as the code compiles and tests pass. good first issue Good for newcomers source/dogstatsd DogStatsD source. type/bug Bug fixes.

Comments

@tobz
Copy link
Member

tobz commented Dec 2, 2024

Context

Title says it all, really.

We effectively want to match the behavior shown here in the Datadog Agent.

@tobz tobz added area/components Sources, transforms, and destinations. area/observability Internal observability of ADP and Saluki. effort/simple Involves trivial changes that should be fine so long as the code compiles and tests pass. good first issue Good for newcomers source/dogstatsd DogStatsD source. type/bug Bug fixes. labels Dec 2, 2024
@tobz
Copy link
Member Author

tobz commented Dec 4, 2024

I'm going to close this for now as "won't do."

In the Datadog Agent, the listener ID, by default, ends up having a value of uds-unix or uds-unixgram, which is essentially identical to the existing transport tag on DogStatsD listener-specific metrics.

The listener ID only gets more useful with "extended" support on, where it throws in the file descriptor of the remote peer as part of the ID, so like uds-unixgram-42 or whatever. Since that's meant purely for very advanced debugging, we're going to punt on this, overall, for now.

@tobz tobz closed this as not planned Won't fix, can't repro, duplicate, stale Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/components Sources, transforms, and destinations. area/observability Internal observability of ADP and Saluki. effort/simple Involves trivial changes that should be fine so long as the code compiles and tests pass. good first issue Good for newcomers source/dogstatsd DogStatsD source. type/bug Bug fixes.
Projects
None yet
Development

No branches or pull requests

1 participant