Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve encoding test #12

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Improve encoding test #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d8de89
Improve encoding test
lloeki Nov 20, 2024
a700aa5
Make musl conformant
lloeki Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/engines/ruby/2.1/Dockerfile.musl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ ARG REPRO_RUN_KEY=0
# updated by changing the `REPRO_RUN_KEY`.
RUN true "${REPRO_RUN_KEY}" && apk update

ENV LANG en_US.UTF-8

## Install a pinned RubyGems and Bundler
RUN gem update --system 2.7.11
RUN gem install bundler --version 1.17.3
Expand Down
2 changes: 2 additions & 0 deletions src/engines/ruby/2.2/Dockerfile.musl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ ARG REPRO_RUN_KEY=0
# updated by changing the `REPRO_RUN_KEY`.
RUN true "${REPRO_RUN_KEY}" && apk update

ENV LANG en_US.UTF-8

## Install a pinned RubyGems and Bundler
RUN gem update --system 2.7.11
RUN gem install bundler --version 1.17.3
Expand Down
2 changes: 2 additions & 0 deletions src/engines/ruby/2.3/Dockerfile.musl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ ARG REPRO_RUN_KEY=0
# updated by changing the `REPRO_RUN_KEY`.
RUN true "${REPRO_RUN_KEY}" && apk update

ENV LANG en_US.UTF-8

## Install a pinned RubyGems and Bundler
RUN gem update --system 3.3.26
RUN gem install bundler:2.3.26
Expand Down
2 changes: 2 additions & 0 deletions src/engines/ruby/2.4/Dockerfile.musl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ ARG REPRO_RUN_KEY=0
# updated by changing the `REPRO_RUN_KEY`.
RUN true "${REPRO_RUN_KEY}" && apk update

ENV LANG en_US.UTF-8

## Install a pinned RubyGems and Bundler
RUN gem update --system 3.3.26
RUN gem install bundler:2.3.26
Expand Down
2 changes: 2 additions & 0 deletions src/engines/ruby/2.5/Dockerfile.musl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ ARG REPRO_RUN_KEY=0
# updated by changing the `REPRO_RUN_KEY`.
RUN true "${REPRO_RUN_KEY}" && apk update

ENV LANG en_US.UTF-8

## Install a pinned RubyGems and Bundler
RUN gem update --system 3.3.26
RUN gem install bundler:2.3.26
Expand Down
2 changes: 2 additions & 0 deletions src/engines/ruby/2.6/Dockerfile.musl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ ARG REPRO_RUN_KEY=0
# updated by changing the `REPRO_RUN_KEY`.
RUN true "${REPRO_RUN_KEY}" && apk update

ENV LANG en_US.UTF-8

## Install a pinned RubyGems and Bundler
RUN gem update --system 3.3.26
RUN gem install bundler:2.3.26
Expand Down
2 changes: 2 additions & 0 deletions src/engines/ruby/2.7/Dockerfile.musl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ ARG REPRO_RUN_KEY=0
# updated by changing the `REPRO_RUN_KEY`.
RUN true "${REPRO_RUN_KEY}" && apk update

ENV LANG en_US.UTF-8

## Install a pinned RubyGems and Bundler
RUN gem update --system 3.3.26
RUN gem install bundler:2.3.26
Expand Down
2 changes: 2 additions & 0 deletions src/engines/ruby/3.0/Dockerfile.musl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ ARG REPRO_RUN_KEY=0
# updated by changing the `REPRO_RUN_KEY`.
RUN true "${REPRO_RUN_KEY}" && apk update

ENV LANG en_US.UTF-8

## Install a pinned RubyGems and Bundler
RUN gem update --system 3.5.21
RUN gem install bundler:2.3.26
Expand Down
2 changes: 2 additions & 0 deletions src/engines/ruby/3.1/Dockerfile.musl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ ARG REPRO_RUN_KEY=0
# updated by changing the `REPRO_RUN_KEY`.
RUN true "${REPRO_RUN_KEY}" && apk update

ENV LANG en_US.UTF-8

## Install a pinned RubyGems and Bundler
RUN gem update --system 3.5.21
RUN gem install bundler:2.3.26
Expand Down
2 changes: 2 additions & 0 deletions src/engines/ruby/3.2/Dockerfile.musl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ ARG REPRO_RUN_KEY=0
# updated by changing the `REPRO_RUN_KEY`.
RUN true "${REPRO_RUN_KEY}" && apk update

ENV LANG en_US.UTF-8

## Install a pinned RubyGems and Bundler
RUN gem update --system 3.5.21
RUN gem install bundler:2.3.26
Expand Down
2 changes: 2 additions & 0 deletions src/engines/ruby/3.3/Dockerfile.musl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ ARG REPRO_RUN_KEY=0
# updated by changing the `REPRO_RUN_KEY`.
RUN true "${REPRO_RUN_KEY}" && apk update

ENV LANG en_US.UTF-8

## Install a pinned RubyGems and Bundler
RUN gem update --system 3.5.21
RUN gem install bundler:2.3.26
Expand Down
2 changes: 2 additions & 0 deletions src/engines/ruby/3.4/Dockerfile.musl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ ARG REPRO_RUN_KEY=0
# updated by changing the `REPRO_RUN_KEY`.
RUN true "${REPRO_RUN_KEY}" && apk update

ENV LANG en_US.UTF-8

## Install a pinned RubyGems and Bundler
RUN gem update --system 3.5.21
RUN gem install bundler:2.3.26
Expand Down
26 changes: 20 additions & 6 deletions test/engines/test_encoding.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,27 @@
require 'minitest/autorun'
require "minitest/autorun"

# polyfill for Ruby 2.2 and down, used by minitest
unless "".respond_to?(:match?)
String.instance_eval do
def match?(other)
(Regexp === other) ? other.match?(self) : (self == other)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚪ Code Quality Violation

Suggested change
(Regexp === other) ? other.match?(self) : (self == other)
(other.is_a?(Regexp)) ? other.match?(self) : (self == other)
Do not use === (...read more)

The case equality operator === in Ruby is used to test equality within a when clause of a case statement. However, it's often considered a bad practice to use this operator explicitly outside of a case statement. This is because its behavior can be quite unpredictable and confusing, as it behaves differently for different classes.

The use of the === operator can lead to code that is harder to read and understand. It's also potentially prone to bugs, as it might not behave as expected with certain objects. Therefore, it's recommended to avoid the explicit use of the === operator.

Instead of using the === operator, it's better to use more explicit methods that clearly indicate what you're trying to achieve. For example, if you're trying to check if a string matches a regular expression, you can use the match? method. If you want to check if an object is an instance of a certain class, you can use the is_a? method. These methods are much more clear and straightforward, leading to better, more maintainable code.

View in Datadog  Leave us feedback  Documentation

end
end
end

class TestEncoding < Minitest::Test
def test_utf8
assert_equal("".encoding, Encoding::UTF_8)
def test_utf8_lang
assert_equal("en_US.UTF-8", ENV["LANG"])
end

def test_utf8_string
assert_equal(Encoding::UTF_8, "".encoding)
end

def test_read_utf8
contents = File.read('test/fixtures/encoding/utf-8.txt')
assert_equal(contents.encoding, Encoding::UTF_8)
assert_equal(contents, "\u2705\n")
contents = File.read("test/fixtures/encoding/utf-8.txt")

assert_equal(Encoding::UTF_8, contents.encoding)
assert_equal("\u2705\n", contents)
end
end