Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix oracledb ci job using a node version incompatible with container #4943

Merged
merged 5 commits into from
Nov 26, 2024
Merged

fix oracledb ci job using a node version incompatible with container #4943

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
befd612
remove setup-node for oracledb ci job
rochdev Nov 26, 2024
b292f8a
debug
rochdev Nov 26, 2024
691c4e7
install unofficial node
rochdev Nov 26, 2024
a7f9830
restore setup node
rochdev Nov 26, 2024
2541d9f
code cleanup
rochdev Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/plugins.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,7 +802,11 @@ jobs:
# TODO: Figure out why nyc stopped working with EACCESS errors.
oracledb:
runs-on: ubuntu-latest
container: bengl/node-12-with-oracle-client
container:
image: bengl/node-12-with-oracle-client
volumes:
- /node20217:/node20217:rw,rshared
- /node20217:/__e/node20:ro,rshared
services:
oracledb:
image: gvenzl/oracle-xe:18-slim
Expand All @@ -827,6 +831,11 @@ jobs:
# Needed to fix issue with `actions/checkout@v3: https://github.com/actions/checkout/issues/1590
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true
steps:
# https://github.com/actions/runner/issues/2906#issuecomment-2109514798
- name: Install Node for runner (with glibc 2.17 compatibility)
run: |
curl -LO https://unofficial-builds.nodejs.org/download/release/v20.9.0/node-v20.9.0-linux-x64-glibc-217.tar.xz
tar -xf node-v20.9.0-linux-x64-glibc-217.tar.xz --strip-components 1 -C /node20217
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
Expand Down
Loading