Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to certifi when using slim docker containers #812

Open
minsis opened this issue Jan 28, 2022 · 1 comment
Open

Default to certifi when using slim docker containers #812

minsis opened this issue Jan 28, 2022 · 1 comment

Comments

@minsis
Copy link

minsis commented Jan 28, 2022

The urllib3 package defaults to using system certs, however, if they aren't there its never detected by urllib3. It would be nice if the Datadog API client could at the very least detect this and default to certifi.

This is relevant for doing pure python docker containers with the need for extra install overhead with the OS package manager. In my case I pull from the official python docker in order to build my WSGI apps.

Thankfully there's a workaround since the Configuration object passes a lot of the same options into urllb3 I'm able to add it.

Configuration(
            ssl_ca_cert=certifi.where()
)
@github-actions
Copy link

Thanks for your contribution!

This issue has been automatically marked as stale because it has not had activity in the last 30 days. Note that the issue will not be automatically closed, but this notification will remind us to investigate why there's been inactivity. Thank you for participating in the Datadog open source community.

If you would like this issue to remain open:

  1. Verify that you can still reproduce the issue in the latest version of this project.

  2. Comment that the issue is still reproducible and include updated details requested in the issue template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant