Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rebase-strategy into each updates element #5176

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

adamnovak
Copy link
Member

@adamnovak adamnovak commented Dec 3, 2024

Changelog Entry

To be copied to the draft changelog by merger:

  • Dependabot configuration should now pass schema validation and is itself under CI

Reviewer Checklist

  • Make sure it is coming from issues/XXXX-fix-the-thing in the Toil repo, or from an external repo.
    • If it is coming from an external repo, make sure to pull it in for CI with:
      contrib/admin/test-pr otheruser theirbranchname issues/XXXX-fix-the-thing
      
    • If there is no associated issue, create one.
  • Read through the code changes. Make sure that it doesn't have:
    • Addition of trailing whitespace.
    • New variable or member names in camelCase that want to be in snake_case.
    • New functions without type hints.
    • New functions or classes without informative docstrings.
    • Changes to semantics not reflected in the relevant docstrings.
    • New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
    • New features without tests.
  • Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
  • Finish the review with an overall description of your opinion.

Merger Checklist

  • Make sure the PR passed tests, including the Gitlab tests, for the most recent commit in its branch.
  • Make sure the PR has been reviewed. If not, review it. If it has been reviewed and any requested changes seem to have been addressed, proceed.
  • Merge with the Github "Squash and merge" feature.
    • If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
  • Copy its recommended changelog entry to the Draft Changelog.
  • Append the issue number in parentheses to the changelog entry.

@adamnovak adamnovak linked an issue Dec 3, 2024 that may be closed by this pull request
@adamnovak
Copy link
Member Author

Dependabot seems to come by and validate our schema whenever it feels like; we can't really require its Github Actions check for PRs.

There's a schema https://json.schemastore.org/dependabot-2.0.json we could check with a separate tool as a CI test.

@adamnovak
Copy link
Member Author

I'm going to just merge this since it is only test changes and fixes CI.

@adamnovak adamnovak merged commit 8e0d84a into master Dec 5, 2024
4 checks passed
@adamnovak adamnovak deleted the issues/5175-appease-dependabot branch December 5, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependabot config is broken
1 participant