Separate unread and read stats and logging files and avoid a circular rename #5141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might fix #1727 by definitively moving stats and logging files from a
stats/inbox
directory to astats/archive
directory when the leader processes them. It no longer renames them back to the.new
suffix they had when they were being written, which avoids trying to directly undo a rename that just happened from another node, which is a thing that a very broken filesystem might find confusing.This also means we don't need to scan through all previously-processed stats and logging files to find new ones; we only have to scan
stats/inbox
.Changelog Entry
To be copied to the draft changelog by merger:
stats/inbox
andstats/archive
and avoid a circular rename.Reviewer Checklist
issues/XXXX-fix-the-thing
in the Toil repo, or from an external repo.camelCase
that want to be insnake_case
.docs/running/{cliOptions,cwl,wdl}.rst
Merger Checklist