-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage of boto (not boto3) prevents toil from working with Python3.12 #4718
Comments
@adamnovak @DailyDreaming any advice here? |
We could probably take the approach taken by that patch to eliminate imp, but we'd want to cut the functions it is just bypassing. We'd like to switch away from boto, but we don't actually use the AWS logic so much here at UCSC anymore and so we don't have an internal fire we need to put out to motivate doing it in house. @DailyDreaming: you're revising the S3 integration, right? How much ripping out of |
|
I think I changed the With the ported code to boto3 though Python 3.12 should be pretty easy to do, and the development branch builds with python 3.12 locally. I can add it to CI later. |
Am Wed, Apr 10, 2024 at 08:01:00AM -0700 schrieb stxue1:
With the ported code to boto3 though Python 3.12 should be pretty easy to do, and the [development branch](https://github.com/DataBiosphere/toil/tree/issues/4718-boto-python-312-all) builds with python 3.12 locally. I can add it to CI later.
Sounds great. I hope this branch will make it into the next release. Thanks a lot, Andreas.
|
Thank you @stxue1 @adamnovak ! |
Hi,
Debian is currently transitioning to Python3.12. Inside
setup.py
of toil I've found the usage ofimp
and the comment that it is known that this modules is deprecated but usage of its successorimportlib
would not be possible. To work around this I wrote a small patch where I'm simply using a shell command to obtain the version. I'd recommend to replaceimp
somehow (more?) sensibly to follow Python3 progress sooner or later.The more concerning issue is the usage of boto. In issue #3951 of boto authors wrote:
Thus I strongly recommend to switch to
boto3
before your next release.Kind regards, Andreas.
┆Issue is synchronized with this Jira Story
┆Issue Number: TOIL-1468
The text was updated successfully, but these errors were encountered: