Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for kubernetes.io/dockerconfigjson #25

Open
Sayrus opened this issue Sep 22, 2019 · 2 comments
Open

add support for kubernetes.io/dockerconfigjson #25

Sayrus opened this issue Sep 22, 2019 · 2 comments

Comments

@Sayrus
Copy link

Sayrus commented Sep 22, 2019

Hello,

I am currently using an operator which requires a .docker/config.json instead of .dockercfg.
Would that be possible to implement the secret type kubernetes.io/dockerconfigjson. It seems that it is the recommended way now and I can't find many recent mentions of kubernetes.io/dockercfg but I can't find any deprecation or reason for that either.

The main difference is the field name named .dockerconfigjson instead of .dockercfg and it contains a Docker auth token instead of username/password/email.

It would be awesome if the operator could transform username/password into a Docker Auth Token but that seems a bit harder than just pulling the token directly from Vault.

Also it might be interesting to add on the documentation that DOCKERCFG only works with KV1 or will fail with KV2 (or maybe it is not intended, if so I can try to provide more information on a separate issue).

It seems duplicating the current DOCKERCFG implementation can create a DOCKERCONFIGJSON that pulls the auth token easily. I can provide a PR for this if you want me to. However, it makes sense to support both username/password and auth token (as kubectl does, I have not checked how it is implemented there).

Best Regards,

@felipem1210
Copy link

This would be a great implementation. Did you make it?

@Sayrus
Copy link
Author

Sayrus commented Oct 4, 2021

This would be a great implementation. Did you make it?

Unfortunately, we stopped using the project so we haven't made an implementation for this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants