Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] Navigate the search suggestions with the arrow keys and enter #152

Open
DarkIntaqt opened this issue Mar 3, 2023 · 2 comments
Open

[FR] Navigate the search suggestions with the arrow keys and enter #152

DarkIntaqt opened this issue Mar 3, 2023 · 2 comments
Assignees
@DarkIntaqt
Labels
low priority Issues or PR with this label won't be prioritised new feature New ideas like feature requests usability
Milestone
NextJS Migration

Comments

@DarkIntaqt
Copy link
Owner

On the start search bar.
Could also be #136 #142
@DarkIntaqt DarkIntaqt added low priority Issues or PR with this label won't be prioritised new feature New ideas like feature requests usability labels Mar 3, 2023
@DarkIntaqt DarkIntaqt added this to the NextJS Migration milestone Mar 31, 2023
@BlossomiShymae
Copy link
Contributor

Hiya! Is it this search bar here?

image

If I press TAB right now when the input bar is focused, it closes the search results dialog. Pressing TAB should probably focus on the search results dialog so the arrow keys can work :3

@DarkIntaqt
Copy link
Owner Author

DarkIntaqt commented Apr 2, 2023 •
edited
Loading

Yeah that currently is the search bar :/ It currently adds a class if the search input is focused, on blur the class is removed again.
This is probably not optimal but it was currently the best option without passing states around

@DarkIntaqt DarkIntaqt self-assigned this Apr 4, 2023
DarkIntaqt added a commit that referenced this issue Apr 4, 2023
@DarkIntaqt
#152 made the searchbar visible while its hovered
e8c4fdf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DarkIntaqt DarkIntaqt

Labels
low priority Issues or PR with this label won't be prioritised new feature New ideas like feature requests usability
Projects
None yet
Milestone
NextJS Migration
Development

No branches or pull requests
2 participants
@DarkIntaqt @BlossomiShymae