Add CTest support and option to skip test progs #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cho-m
force-pushed
the
cmake-allow-skipping-test-progs
branch
from
6738e2c
to
db39664
Compare
cho-m
changed the title
|
Not entirely sure on test cases. Seems to run. However, I think the full test suite will fail without |
|
The primary building tools are autotools. I am not sure if it make sense to run the same with another build system (cmake). This is the reason why did not build progs with cmake (not to waste resources and time). |
cho-m
force-pushed
the
cmake-allow-skipping-test-progs
branch
from
db39664
to
15a997a
Compare
cho-m
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fix #759 when building for distribution that doesn't care about test programs. Similar idea to how CTest
-DBUILD_TESTING=OFFor GNOME's common meson-Dtests=disabledusually avoids compiling unnecessary files.Build can still fail on Linux/glibc when
-DBUILD_TESTING=ONas some progs needs-lmbut lower priority for packaging which is my main concern.Used
BUILD_TESTINGoption as that is default for CTest1 so can be compatible if future switch toinclude(CTest).Note that CI does not test this as
BUILD_PROG=OFFfor Linux:leptonica/.github/workflows/cmake.yml
Line 46 in 96a3d74
Footnotes
https://cmake.org/cmake/help/latest/module/CTest.html ↩