From 2b01dc93a66514b83b174472a90779ce8d85e4f9 Mon Sep 17 00:00:00 2001 From: p3rf Team Date: Wed, 10 May 2023 12:29:42 -0700 Subject: [PATCH] Remove unused flag --ycsb_log_remote_command_output PiperOrigin-RevId: 530976627 --- CHANGES.next.md | 2 -- perfkitbenchmarker/linux_packages/ycsb.py | 4 ---- .../batch_configs/parallel_tests/runner.yaml | 1 - .../batch_configs/sequential_tests/runner.yaml | 1 - .../batch_configs/templates/runner_config.yaml | 1 - 5 files changed, 9 deletions(-) diff --git a/CHANGES.next.md b/CHANGES.next.md index 190887a4be..e39cb4a5a9 100644 --- a/CHANGES.next.md +++ b/CHANGES.next.md @@ -180,8 +180,6 @@ - Add additional customization options to SPEC CPU 2017. - Add average utilization to the metadata of cpu metrics for Cloud Bigtable benchmark. -- Add flag --ycsb_log_remote_command_output to allow enabling/disabling the - logging of stdout & stderr from wait_for_command. - Add support for NFS `nconnect` mount option. - Add support for custom compilation of OpenJDK. - Add support for configuring the HBase binding to use with `--hbase_binding`. diff --git a/perfkitbenchmarker/linux_packages/ycsb.py b/perfkitbenchmarker/linux_packages/ycsb.py index c3c5cfdd45..cef793a632 100644 --- a/perfkitbenchmarker/linux_packages/ycsb.py +++ b/perfkitbenchmarker/linux_packages/ycsb.py @@ -215,10 +215,6 @@ 'if we have already reached sustained throughput.') flags.DEFINE_integer('ycsb_sleep_after_load_in_sec', 0, 'Sleep duration in seconds between load and run stage.') -flags.DEFINE_boolean( - 'ycsb_log_remote_command_output', True, - 'Whether to log the remote command\'s output at the info ' - 'level.') _BURST_LOAD_MULTIPLIER = flags.DEFINE_integer( 'ycsb_burst_load', None, 'If set, applies burst load to the system, by running YCSB once, and then ' diff --git a/tutorials/bigtable_walkthrough/batch_configs/parallel_tests/runner.yaml b/tutorials/bigtable_walkthrough/batch_configs/parallel_tests/runner.yaml index b01c2023e0..4efbf3d6de 100644 --- a/tutorials/bigtable_walkthrough/batch_configs/parallel_tests/runner.yaml +++ b/tutorials/bigtable_walkthrough/batch_configs/parallel_tests/runner.yaml @@ -33,7 +33,6 @@ runner: hadoop_bin_url: https://storage.googleapis.com/cbt_ycsb_client_jar/hadoop-3.3.1.tar.gz google_bigtable_client_version: 2.5.0 ycsb_version: 0.17.0 - ycsb_log_remote_command_output: false ################################# # YCSB result settings diff --git a/tutorials/bigtable_walkthrough/batch_configs/sequential_tests/runner.yaml b/tutorials/bigtable_walkthrough/batch_configs/sequential_tests/runner.yaml index 55750e52e1..45889ef06a 100644 --- a/tutorials/bigtable_walkthrough/batch_configs/sequential_tests/runner.yaml +++ b/tutorials/bigtable_walkthrough/batch_configs/sequential_tests/runner.yaml @@ -37,7 +37,6 @@ runner: hadoop_bin_url: https://storage.googleapis.com/cbt_ycsb_client_jar/hadoop-3.3.1.tar.gz google_bigtable_client_version: 2.5.0 ycsb_version: 0.17.0 - ycsb_log_remote_command_output: false ################################# # YCSB result settings diff --git a/tutorials/bigtable_walkthrough/batch_configs/templates/runner_config.yaml b/tutorials/bigtable_walkthrough/batch_configs/templates/runner_config.yaml index e5e7de6bb0..04d08a2960 100644 --- a/tutorials/bigtable_walkthrough/batch_configs/templates/runner_config.yaml +++ b/tutorials/bigtable_walkthrough/batch_configs/templates/runner_config.yaml @@ -64,7 +64,6 @@ runner: hadoop_bin_url: https://storage.googleapis.com/cbt_ycsb_client_jar/hadoop-3.3.1.tar.gz google_bigtable_client_version: 2.5.0 ycsb_version: 0.17.0 - ycsb_log_remote_command_output: false ################################# # YCSB result settings