Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support factory contracts #27

Open
rossneilson opened this issue Aug 30, 2022 · 3 comments · May be fixed by DXgovernance/DAVI#294
Open

Support factory contracts #27

rossneilson opened this issue Aug 30, 2022 · 3 comments · May be fixed by DXgovernance/DAVI#294
Assignees
Labels
Action Builder Related to the action builder app:Frontend

Comments

@rossneilson
Copy link
Contributor

User Story
As a proposer I want to be able to call factory generated contracts without adding listings for each individual contract.

Alternative Solutions
Instead of specifying an address we will set the address to a specific value e.g. 0x99999999999
We then need an optional new hashed bytecode value in the rich contract schema that is read in these situations.

When creating a proposal with the specific address (0x99999999999) we know this is a factory contract and so will ask the user first in a modal to specify the address of the contract and we will set this as the to value. Here we can also verify the supplied address by comparing hashed bytecodes.
Then the user would simply get the usual param form for that contract.

Then in addition to finding trying to match addresses when decoding we should also check against hashed bytecode for a match.

This isn't the best solution because it requires some manual work from the user to find the contract address but we can improve this in future.

@rossneilson
Copy link
Contributor Author

We should be able to test this by calling release on ERC20VestingFactory generated contracts in localhost

@rossneilson
Copy link
Contributor Author

DXgovernance/DAVI#294

@rossneilson rossneilson transferred this issue from DXgovernance/DAVI Jan 2, 2023
@rossneilson rossneilson added this to the 2023 - Sprint 7 milestone Mar 30, 2023
@rossneilson rossneilson moved this from Review to Backlog in Sprints Mar 30, 2023
@rossneilson
Copy link
Contributor Author

This fell behind, we did have a PR but now we can include it in rich contracts v2

@rossneilson rossneilson added the Action Builder Related to the action builder label Mar 30, 2023
@rulfo71 rulfo71 removed their assignment Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Action Builder Related to the action builder app:Frontend
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

3 participants