Add error handling for API errors #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakub-Vacek
approved these changes
Nov 2, 2020
|
Nicely done 🤩👍 |
Jakub-Vacek
added
the
hacktoberfest-accepted
evnik
reviewed
Nov 3, 2020
|
|
||
| import Foundation | ||
|
|
||
| enum Result<T> { |
There was a problem hiding this comment.
You might just use Swift.Result instead of introducing a new enum
| case emptyResponse | ||
| case invalidDate | ||
| case configurationNotFound | ||
| enum ApiError: String, Error { |
There was a problem hiding this comment.
Please use LocalizedError.errorDescription for this purpose, instead of rawValue
Pipeliner/ContentView.swift
Outdated
| pipelinerService.getProjectName(baseUrl: baseUrl, projectId: projectId, token: token) { (result) in | ||
| switch result { | ||
| case .success(let projectName): | ||
| print(projectName) |
There was a problem hiding this comment.
Please keep configurations update and reload here
Pipeliner/ContentView.swift
Outdated
| WidgetCenter.shared.reloadAllTimelines() | ||
|
|
||
| } else { | ||
| savedBaseUrl = "not found" |
There was a problem hiding this comment.
savedBaseUrl seems to be unused anymore. Please remove it
| let project = try JSONDecoder().decode(Project.self, from: data) | ||
|
|
||
| guard let data = try? await(httpService.getData(request: request)) else { | ||
| throw ApiError.emptyResponse |
There was a problem hiding this comment.
Please don't drop the original error, because it might include relevant info for issue debugging.
Pipeliner/PipelinerService.swift
Outdated
| do { | ||
| return try gitLabService.getProjectName(baseUrl: baseUrl, projectId: projectId, token: token) | ||
| let projectName = try gitLabService.getProjectName(baseUrl: baseUrl, projectId: projectId, token: token) | ||
| completion(.success(projectName)) |
There was a problem hiding this comment.
What is the reason to make this asynchronous?
…dling # Conflicts: # Pipeliner/ContentView.swift # Pipeliner/GitHub/GitHubService.swift # Pipeliner/PipelinerService.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7