Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PipelinerService to work with pull requests #15

Open
Jakub-Vacek opened this issue Sep 21, 2020 · 0 comments
Open

Refactor PipelinerService to work with pull requests #15

Jakub-Vacek opened this issue Sep 21, 2020 · 0 comments
Labels
Epic: Pull Requests App supports pull requests Status: Available Issue is available

Comments

@Jakub-Vacek
Copy link
Collaborator

Refactor and rename method getPipelines in class PipelinerService to return array of Result objects containing attributes:

  • type: Enum - type of data in data attribute, it can have values pipeline or pullRequest
  • data: PipelineResult or PullRequestResult - PullRequestResult object contains:
    • id: Int
    • name: String - name of pull request
    • url: String - web url to pull request
    • state: Enum - state of pull request inProgress or merged or closed
    • age: String - age of pull request formated using DateService and createdAt attribute
    • duration: String - duration of pull request formated using DateService and lastActivityAt attribute
    • repositoryName: String - name of pull request repository

Depends on #12, #13 and #14

@Jakub-Vacek Jakub-Vacek added Status: Available Issue is available Epic: Pull Requests App supports pull requests Hacktoberfest https://hacktoberfest.digitalocean.com labels Sep 21, 2020
@prokopsimek prokopsimek removed the Hacktoberfest https://hacktoberfest.digitalocean.com label Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic: Pull Requests App supports pull requests Status: Available Issue is available
Projects
None yet
Development

No branches or pull requests

2 participants