Feat/week6 essential #11

jihyun0v0 · 2023-11-28T14:46:51Z

📌𝘐𝘴𝘴𝘶𝘦𝘴

closed week6 필수과제 #10

📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯

새로운 id, password 조건 만들기
edit text를 textInputLayout으로 만들어서 에러 메세지 적용할 수 있게 하기
data binding을 활용하여 mvvm패턴 연습하기

📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵

Recording_2023-11-28-23-36-33.mp4

💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴

이번주도 잘부탁드립니다(꾸벅)

Marchbreeze

훈수두러왔다가 감동받고 갑니다 ... 코드 퀄리티 너무 좋네요 !!!!

Marchbreeze · 2023-11-28T16:35:05Z

app/src/main/java/org/sopt/dosopttemplate/api/FollowerService.kt

+private const val REQURES_BASE_URL =  BuildConfig.REQRES_BASE_URL
+
+interface FollowerService {
+    @GET(REQURES_BASE_URL)


요 부분에 AuthService와 다르게 BASE_URL을 넣은 이유가 뭔가요? BASE_URL은 이 FollowerService를 사용하는 ServicePool에서 넣어주는 것으로 보이는데!

Marchbreeze · 2023-11-28T16:36:30Z

app/src/main/java/org/sopt/dosopttemplate/api/ResponseGetFollowerDto.kt

+import kotlinx.serialization.Serializable
+
+@Serializable
+data class ResponseGetFollwerDto(


Suggested change

data class ResponseGetFollwerDto(

@Serializable

data class FollowerResponseDto(

@SerialName("page")

val page: Int,

@SerialName("per_page")

val perPage: Int,

@SerialName("total")

val total: Int,

@SerialName("total_pages")

val totalPages: Int,

@SerialName("data")

val data: List<User>,

@SerialName("support")

val support: Support,

) {

@Serializable

data class User(

@SerialName("id")

val id: Int,

@SerialName("email")

val email: String,

@SerialName("first_name")

val firstName: String,

@SerialName("last_name")

val lastName: String,

@SerialName("avatar")

val avatar: String

)

@Serializable

data class Support(

@SerialName("url")

val url: String,

@SerialName("text")

val text: String

)

}

저는 이런식으로 data class 계층을 주어서 종속되도록 표현해두었어요! 물론 이것은 취향차이입니다 ~~~

Marchbreeze · 2023-11-28T16:37:48Z

app/src/main/java/org/sopt/dosopttemplate/presentation/editMyPage/EditMyPageViewModel.kt

    fun setNewProfile(): Profile {
-        if (!(mbti.value.isNullOrEmpty())) profile.MBTI = mbti.value.toString()
-        if (!(musicTitle.value.isNullOrEmpty())) profile.musicTitle = musicTitle.value.toString()
-        if (!(musicArtist.value.isNullOrEmpty())) profile.musicArtist = musicArtist.value.toString()
-        if (!(intro.value.isNullOrEmpty())) profile.intro = intro.value.toString()
-        profile.setMusic()
-//        logProfile(profile)
+        if (!(mbti.value.isNullOrEmpty())) profile.setMbti(mbti.value.toString())
+        if (!(musicTitle.value.isNullOrEmpty()) && !(musicArtist.value.isNullOrEmpty()))
+            profile.setMusic(musicTitle.value.toString(), musicArtist.value.toString())
+        if (!(intro.value.isNullOrEmpty())) profile.setIntro(intro.value.toString())


뷰모델의 용도를 정확하게 이해하고 계시네요... 최고최고

Marchbreeze · 2023-11-28T16:38:33Z

app/src/main/java/org/sopt/dosopttemplate/presentation/editMyPage/EditMyPageActivity.kt

+        binding.viewModel = editMyPageViewModel
+        editMyPageViewModel.setProfile(myProfile)
+        editMyPageViewModel.initPage()


저는 모두 함수화를 진행해둬서 onCreate() 안에 제가 지정한 함수들만 있도록 깔끔하게 정리해두는 편이에요!

Marchbreeze · 2023-11-28T16:39:14Z

app/src/main/java/org/sopt/dosopttemplate/presentation/home/FriendViewHolder.kt

+            Glide.with(binding.root)
+                .load(friendData.reqresData?.avatar)
+                .into(ivProfile)


요즘은 Glide보다 Coil이 더 성능이 좋아 활용하는 추세입니다~~ 어렵지 않으니 한번 알아봐보세요 ㅎㅎ

바인딩 어댑터를 사용해보지 않았다면 바인딩어댑터를 사용하셔서 xml로 사용하여 데바를 활용할 수 있습니다 (추천은아님)

Marchbreeze · 2023-11-28T16:40:04Z

app/src/main/java/org/sopt/dosopttemplate/presentation/home/HomeFragment.kt

+    private var _profileAdapter: ProfileAdapter? = null
+    val profileAdapter: ProfileAdapter
+        get() = requireNotNull(_profileAdapter) { "profileAdapter not initialized" }


요렇게 백패킹을 활용했다면, _adapter를 화면이 종료될때 null로 해재시켜줘야 의미를 얻을 수 있겠죠?

Marchbreeze · 2023-11-28T16:40:36Z

app/src/main/java/org/sopt/dosopttemplate/presentation/home/HomeFragment.kt

+        getFollowerList()
+    }
+
+    private fun getFollowerList() {


앞에서 잘 나누어주셨던 것처럼, 이부분도 뷰모델로 옮겨봅시다 ~!

Marchbreeze · 2023-11-28T16:41:36Z

app/src/main/res/layout/activity_login.xml

+                android:onTextChanged="@{() -> authViewModel.onIDTextChanged()}"
+                android:text="@={authViewModel._id}"


어우 야무지네요..

chattymin

매주 가파르게 성장하시네요 ㄷㄷ

chattymin · 2023-12-05T02:10:51Z

app/src/main/res/layout/activity_login.xml

-            android:hint="@string/pw_hint"
-            android:inputType="textPassword"
-            android:text="@={viewModel.password}"
+            app:errorEnabled="@{authViewModel.passwordConditionSatisfied == false? true: false}"


true는 false로, false는 true로 바꾸는 코드 같은데 !로 바꾸는게 더 가독성이 좋을 것 같습니다!!

Suggested change

app:errorEnabled="@{authViewModel.passwordConditionSatisfied == false? true: false}"

app:errorEnabled="@{!authViewModel.passwordConditionSatisfied}"

chattymin · 2023-12-05T02:12:40Z

app/src/main/java/org/sopt/dosopttemplate/util/UtilClass.kt

+    fun isIdConditionSatisfied(str: String): Boolean {
+        val englishAndNumRegex: Regex = Regex("^(?=.*[0-9])(?=.*[a-zA-Z]).{6,10}\$")
+        return str.matches(englishAndNumRegex)
+    }
+
+    fun isPasswordConditionSatisfied(str: String): Boolean {
+        val englishAndNumSpecialRegex: Regex = Regex("^(?=.*[0-9])(?=.*[a-zA-Z])(?=.*[!@#\$%^&*()-_=+]).{6,12}\$")
+        return str.matches(englishAndNumSpecialRegex)
+    }


킹의진님이 꿀팁공유에 올려주신 "불필요한 객체 생성의 피해: 정규표현식 객체 최적화"를 보시고 적용해보는 것도 좋을 것 같네요 :)

chattymin · 2023-12-05T02:29:24Z

app/src/main/res/layout/activity_signup.xml

+            android:enabled="@{authViewModel.loginConditionSatisfied}"
+            android:onClick="@{() -> authViewModel.signUp()}"


데이터 바인딩 활용 너무 멋집니다!

stellar-halo

성장 속도가 너무 빨라요!! 멋있다 ~

stellar-halo · 2023-12-08T14:55:11Z

app/src/main/java/org/sopt/dosopttemplate/api/AuthViewModel.kt

@@ -0,0 +1,89 @@
+package org.sopt.dosopttemplate.api// 보시면 알겠지만 LiveData는 lifecycle 라이브러리에 들어있습니다!


주석 처리가 잘못 된 것 같습니다..?

stellar-halo · 2023-12-08T14:55:38Z

app/src/main/java/org/sopt/dosopttemplate/api/AuthViewModel.kt

+    val _id: MutableLiveData<String> = MutableLiveData()
+    val id: String get() = _id.value ?: ""
+    val _password: MutableLiveData<String> = MutableLiveData()
+    val password: String get() = _password.value ?: ""
+    val _nickName: MutableLiveData<String> = MutableLiveData()
+    val nickName: String get() = _nickName.value ?: ""


반복되는 작업을 한 번에 처리할 수는 없을까요? 한 번 고민해보세요!

stellar-halo · 2023-12-08T14:55:57Z

app/src/main/java/org/sopt/dosopttemplate/api/AuthViewModel.kt

+                    signUpSuccess.value = false
+                }
+            }.onFailure {
+                // 에러 처리


로그 출력도 하나의 방법입니다!

stellar-halo · 2023-12-08T14:58:26Z

app/src/main/java/org/sopt/dosopttemplate/presentation/login/LoginActivity.kt

+    private fun observeId() {
+        authViewModel.idConditionSatisfied.observe(this) {
+            if (it == false && authViewModel.id.isNotBlank()) {
+                binding.tilId.error = "영문, 숫자가 포함된 6~10글자를 입력해주세요."


databinding을 쓰고 있으니 xml에서도 처리가 가능한 코드입니다!

crownjoe

이렇게 데바 이용하는 거군요!!! 배워갑니다 👍👍이번 주도 수고하셨슴니다!!

crownjoe · 2023-12-08T15:27:09Z

app/src/main/java/org/sopt/dosopttemplate/api/AuthViewModel.kt

+    val isLoginButtonClicked: MutableLiveData<Boolean> = MutableLiveData(false)
+    val idConditionSatisfied: MutableLiveData<Boolean> = MutableLiveData(false)
+    val passwordConditionSatisfied: MutableLiveData<Boolean> = MutableLiveData(false)
+    val loginConditionSatisfied: MutableLiveData<Boolean> = MutableLiveData(idConditionSatisfied.value?:false && passwordConditionSatisfied.value?:false)


요렇게 라이브데이터 시작하는 거군요!!

crownjoe · 2023-12-08T15:27:51Z

app/src/main/java/org/sopt/dosopttemplate/api/ResponseGetFollowerDto.kt

+    val lastName: String,
+    @SerialName("avatar")
+    val avatar: String,
+)


이렇게 한 번에 쓰니까 더 깔끔한 것 같아요!

lsakee

고생하셨숩니다

lsakee · 2023-12-10T11:18:36Z

app/src/main/java/org/sopt/dosopttemplate/api/AuthViewModel.kt

+    val isLoginButtonClicked: MutableLiveData<Boolean> = MutableLiveData(false)
+    val idConditionSatisfied: MutableLiveData<Boolean> = MutableLiveData(false)
+    val passwordConditionSatisfied: MutableLiveData<Boolean> = MutableLiveData(false)
+    val loginConditionSatisfied: MutableLiveData<Boolean> = MutableLiveData(idConditionSatisfied.value?:false && passwordConditionSatisfied.value?:false)


요로직들 데이터 바인딩을 활용하신다면 xml로 이전하는 방법도 있는데 모르셨다면 한번 사용해보는 방법도 좋울거 같습니다.

lsakee · 2023-12-10T11:19:38Z

app/src/main/java/org/sopt/dosopttemplate/api/FollowerService.kt

+import retrofit2.Call
+import retrofit2.http.GET
+
+private const val REQURES_BASE_URL =  BuildConfig.REQRES_BASE_URL


요부분 레트로핏으로 이동해도 좋을덧

lsakee · 2023-12-10T11:22:06Z

app/src/main/java/org/sopt/dosopttemplate/presentation/home/FriendViewHolder.kt

+            Glide.with(binding.root)
+                .load(friendData.reqresData?.avatar)
+                .into(ivProfile)


바인딩 어댑터를 사용해보지 않았다면 바인딩어댑터를 사용하셔서 xml로 사용하여 데바를 활용할 수 있습니다 (추천은아님)

kez-lab

고생했습니다~!!

kez-lab · 2023-12-08T06:27:02Z

app/src/main/java/org/sopt/dosopttemplate/api/AuthViewModel.kt

+        viewModelScope.launch {
+            kotlin.runCatching {
+                authService.signUp(RequestSignUpDto(id, nickName, password))
+            }.onSuccess {
+                if (it.isSuccessful) {
+                    signUpResult.value = it.body()
+                    signUpSuccess.value = true
+                } else {
+                    signUpSuccess.value = false
+                }
+            }.onFailure {
+                // 에러 처리
+            }
+        }
+    }


runCatching으로 서버 응답 핸들링하실거라면 반환값이 Response 구조가 아닌 DTO 구조로 변경해야할 것 같습니다~!!

kez-lab · 2023-12-08T06:28:38Z

app/src/main/java/org/sopt/dosopttemplate/data/Profile.kt

+@Parcelize
+data class subInfo(
+    var music: Music?,
+    var MBTI: String,
+    var intro: String,
+) : Parcelable {
+    fun getMusic(): String = music?.string ?: "no music"
+
+    constructor(music: Music?) : this(music, "", "")
+}


굳이 보조 생성자 안만들고 default value를 사용하면 될 것 같습니당

getMusic도 defaultValue를 활용한다면 nullable하지 않아도 되니 해당 함수의 삭제가 가능하겠네요!

kez-lab · 2023-12-08T06:32:14Z

app/src/main/java/org/sopt/dosopttemplate/presentation/home/FriendViewHolder.kt

+            Glide.with(binding.root)
+                .load(friendData.reqresData?.avatar)
+                .into(ivProfile)


onBind는 굉장히 많이 호출되고 있는 함수입니다. Glide 객체를 그때마다 생성하게 될텐데요! 이걸 잘 해결해보시면 좋을 것 같네용

jihyun0v0 added 16 commits November 14, 2023 01:15

[feat]서버 통신login 구현

9998234

[feat] 회원가입 서버 통신 구현

15ed22d

[feat] reqres 서버통신 구현, follower list 만들기 구현

7ca105e

[refact] profile data class refactoring

108913b

[refact] refactoring

eb1e6b0

[chore] reformatting

a45a98e

[chore] rename ResponseGetFollowerDto

17d2e78

[chore] data class 순서 변경

7d7c35a

[chore] 주석 삭제

387932c

[chore] reformat

aa1f61b

[chore] requireNotNull 사용해보기

d29b3a3

[feat] data binding

3da6983

[feat] 데이터 바인딩

f8c7af2

[chore] login 화면 데이터 바인딩으로 조건확인하기

b5522dd

[feat] 새로운 id, password 조건 추가, text input layout 활용

5ea02c7

[feat] 빈칸일 때 error 메세지 띄우지 않기 기능 추가

ab5e21f

jihyun0v0 added the 필수과제 DOSOPT 필수과제 label Nov 28, 2023

jihyun0v0 requested review from chattymin, stellar-halo, lsakee, kez-lab, Marchbreeze, taeheeL and crownjoe November 28, 2023 14:46

jihyun0v0 self-assigned this Nov 28, 2023

Marchbreeze reviewed Nov 28, 2023

View reviewed changes

chattymin reviewed Dec 5, 2023

View reviewed changes

stellar-halo approved these changes Dec 8, 2023

View reviewed changes

crownjoe reviewed Dec 8, 2023

View reviewed changes

lsakee reviewed Dec 10, 2023

View reviewed changes

kez-lab approved these changes Dec 10, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/week6 essential #11

Feat/week6 essential #11

jihyun0v0 commented Nov 28, 2023

Marchbreeze left a comment

Marchbreeze Nov 28, 2023

Marchbreeze Nov 28, 2023

Marchbreeze Nov 28, 2023

Marchbreeze Nov 28, 2023

Marchbreeze Nov 28, 2023

lsakee Dec 10, 2023

Marchbreeze Nov 28, 2023

Marchbreeze Nov 28, 2023

Marchbreeze Nov 28, 2023

chattymin left a comment

chattymin Dec 5, 2023

chattymin Dec 5, 2023

chattymin Dec 5, 2023

stellar-halo left a comment

stellar-halo Dec 8, 2023

stellar-halo Dec 8, 2023

stellar-halo Dec 8, 2023

stellar-halo Dec 8, 2023

crownjoe left a comment

crownjoe Dec 8, 2023

crownjoe Dec 8, 2023

lsakee left a comment

lsakee Dec 10, 2023

lsakee Dec 10, 2023

lsakee Dec 10, 2023

kez-lab left a comment

kez-lab Dec 8, 2023

kez-lab Dec 8, 2023

kez-lab Dec 8, 2023

kez-lab Dec 8, 2023

-data class ResponseGetFollwerDto(
+@Serializable
+data class FollowerResponseDto(
+    @SerialName("page")
+    val page: Int,
+    @SerialName("per_page")
+    val perPage: Int,
+    @SerialName("total")
+    val total: Int,
+    @SerialName("total_pages")
+    val totalPages: Int,
+    @SerialName("data")
+    val data: List<User>,
+    @SerialName("support")
+    val support: Support,
+) {
+    @Serializable
+    data class User(
+        @SerialName("id")
+        val id: Int,
+        @SerialName("email")
+        val email: String,
+        @SerialName("first_name")
+        val firstName: String,
+        @SerialName("last_name")
+        val lastName: String,
+        @SerialName("avatar")
+        val avatar: String
+    )
+    @Serializable
+    data class Support(
+        @SerialName("url")
+        val url: String,
+        @SerialName("text")
+        val text: String
+    )
+}

		android:onTextChanged="@{() -> authViewModel.onIDTextChanged()}"
		android:text="@={authViewModel._id}"

	app:errorEnabled="@{authViewModel.passwordConditionSatisfied == false? true: false}"
	app:errorEnabled="@{!authViewModel.passwordConditionSatisfied}"

		android:enabled="@{authViewModel.loginConditionSatisfied}"
		android:onClick="@{() -> authViewModel.signUp()}"

		@@ -0,0 +1,89 @@
		package org.sopt.dosopttemplate.api// 보시면 알겠지만 LiveData는 lifecycle 라이브러리에 들어있습니다!

Feat/week6 essential #11

Are you sure you want to change the base?

Feat/week6 essential #11

Conversation

jihyun0v0 commented Nov 28, 2023

📌𝘐𝘴𝘴𝘶𝘦𝘴

📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯

📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵

💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴

Marchbreeze left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chattymin left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stellar-halo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

crownjoe left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lsakee left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kez-lab left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment