Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs - rename the "visible" properties to "active" #553

Open
X3Technology opened this issue Apr 18, 2022 · 4 comments
Open

Tabs - rename the "visible" properties to "active" #553

X3Technology opened this issue Apr 18, 2022 · 4 comments

Comments

@X3Technology
Copy link

"active" is more accurate (and consistent with the help text). All the tabs are "visible".

@david-poindexter
Copy link
Contributor

Are you talking about the CSS variable names? If so, I tend to agree.

@valadas
Copy link
Member

valadas commented Apr 18, 2022

I am not disagreeing but be aware that this would be a breaking change for consumers, we are still in v0.x.x phase so it is technically possible but the project is already being used in multiple modules... Just if a PR comes in to change it, we need to call attention to it in the release notes.

@X3Technology
Copy link
Author

IMHO, people using a v0 product should expect breaking changes. Better to fix it now than when it has wide spread adoption.

@david-poindexter
Copy link
Contributor

I don't think anyone is refuting that @X3Technology. We just need to treat it semantically as a breaking change (because it is) and call attention to it in the release notes so that developers that are consuming these can update accordingly.

These components have been in use in production extensions for a long time now. So, even though it is pre-v1 and many people are just now taking notice of the project, it has actually been in existence for almost three years now. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants