Add placeholder for Feedback fields and Persian Localization #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion,Country,PostalCode,Telepone,Message fields in form and field setting, Also add Persian (fa-IR) localized files
|
This looks like a solid update, but I'm not the module "owner" at this time. I'll let @valadas or someone else chime in further. |
|
@valadas |
|
It is on my list for open-source stuff. That list is a bit large and I am preparing for DNN Connect the next few weeks of my free time. It looked ok from a quick look but wanted to take the time to look at this properly. |
|
could you please publish this pull request mr valadas? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion,Country,PostalCode,Telepone,Message fields in form and field setting, Also add Persian (fa-IR) localized files
The placeholder is a main part of any textbox so I decided to add this to inputs.
Changes made
I add placeholder field after each input in "Form and Field Setting" section
save the values in ModuleSetting table
and finally show them in feedback form
also I add Persian resx file to localize to persian (fa-IR)