Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C# Conversion #34

Open
valadas opened this issue Sep 21, 2018 · 3 comments
Open

C# Conversion #34

valadas opened this issue Sep 21, 2018 · 3 comments
Assignees
Milestone

Comments

@valadas
Copy link
Member

valadas commented Sep 21, 2018

Module should be converted to C# to be on the same language as all other modules and the platform too.

@valadas valadas added this to the 07.00.00 milestone Sep 21, 2018
@valadas valadas self-assigned this Sep 21, 2018
@valadas
Copy link
Member Author

valadas commented Sep 23, 2018

DNN.Feedback_C.zip

If anyone has time to complete, here is my c# conversion of this module. I would say it is probably like 95% ok, I just think there are issues plugging the event handlers correctly, some fire up some don't. I put it in here just in case someone decides to continues on this, I ran out of time to work on that this week, so I just release 6.6.0 in VB, hopefully the next 7.0.0 version will be C#.

@valadas
Copy link
Member Author

valadas commented Sep 23, 2018

Just a head up if someone tries to fix those issues. Adding the event in the view (ascx) does not appear to work correctly. So I added the events in the init stage of each codebehind file, for some reason some work some don't. Also, for some reason on some controls Init and/or Load fire up twice each time the control is displayde.

@ChrisHammond
Copy link
Contributor

So I'm all for C# and all, but I would say we just leave the module as VB? No real downsides, and wouldn't hurt to have a VB.net example module available....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants