diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3f6a89c9..49561ca7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -51,7 +51,7 @@ jobs: docker run -d -p 5433:5433 -p 5444:5444 \ --mount type=volume,source=vertica-data,target=/data \ --name vertica_ce \ - vertica/vertica-ce:23.3.0-0 + vertica/vertica-ce:23.4.0-0 echo "Vertica startup ..." until docker exec vertica_ce test -f /data/vertica/VMart/agent_start.out; do \ echo "..."; \ diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index f2a7cf37..ec2a1f17 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -11,7 +11,7 @@ This document will guide you through the contribution process. There are a numbe If you find a bug, submit an [issue](https://github.com/vertica/vertica-nodejs/issues) with a complete and reproducible bug report. If the issue can't be reproduced, it will be closed. If you opened an issue, but figured out the answer later on your own, comment on the issue to let people know, then close the issue. -For issues (e.g. security related issues) that are **not suitable** to be reported publicly on the GitHub issue system, report your issues to [Vertica open source team](mailto:vertica-opensrc@microfocus.com) directly or file a case with Vertica support if you have a support account. +For issues (e.g. security related issues) that are **not suitable** to be reported publicly on the GitHub issue system, report your issues to [Vertica open source team](mailto:vertica-opensrc@opentext.com) directly or file a case with Vertica support if you have a support account. # Feature Requests @@ -191,4 +191,4 @@ Pull requests are usually reviewed within a few days. If there are comments to a That's it! Thank you for your code contribution! -After your pull request is merged, you can safely delete your branch and pull the changes from the upstream repository. \ No newline at end of file +After your pull request is merged, you can safely delete your branch and pull the changes from the upstream repository. diff --git a/packages/v-protocol/src/parser.ts b/packages/v-protocol/src/parser.ts index 00e37b3e..d309a601 100644 --- a/packages/v-protocol/src/parser.ts +++ b/packages/v-protocol/src/parser.ts @@ -393,7 +393,7 @@ export class Parser { } break case 5: // AuthenticationMD5Password - if (message.length === 12) { + if (message.length === 32) { message.name = 'authenticationMD5Password' const salt = this.reader.bytes(4) return new AuthenticationMD5Password(length, salt) diff --git a/packages/v-protocol/src/testing/test-buffers.ts b/packages/v-protocol/src/testing/test-buffers.ts index d56b6c01..c0bdf188 100644 --- a/packages/v-protocol/src/testing/test-buffers.ts +++ b/packages/v-protocol/src/testing/test-buffers.ts @@ -36,6 +36,8 @@ const buffers = { return new BufferList() .addInt32(5) .add(Buffer.from([1, 2, 3, 4])) + .addInt32(16) + .add(Buffer.from([1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16])) .join(true, 'R') }, diff --git a/packages/vertica-nodejs/test/integration/client/error-handling-tests.js b/packages/vertica-nodejs/test/integration/client/error-handling-tests.js index 46a0f642..943af84f 100644 --- a/packages/vertica-nodejs/test/integration/client/error-handling-tests.js +++ b/packages/vertica-nodejs/test/integration/client/error-handling-tests.js @@ -10,7 +10,7 @@ const DatabaseError = vertica.DatabaseError var createErorrClient = function () { var client = helper.client() client.once('error', function (err) { - assert.fail('Client shoud not throw error during query execution') + assert.fail('Client should not throw error during query execution') }) client.on('drain', client.end.bind(client)) return client diff --git a/packages/vertica-nodejs/test/test-buffers.js b/packages/vertica-nodejs/test/test-buffers.js index 4cd7b7a1..fc73b7fb 100644 --- a/packages/vertica-nodejs/test/test-buffers.js +++ b/packages/vertica-nodejs/test/test-buffers.js @@ -34,6 +34,8 @@ buffers.authenticationMD5Password = function () { return new BufferList() .addInt32(5) .add(Buffer.from([1, 2, 3, 4])) + .addInt32(16) + .add(Buffer.from([1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16])) .join(true, 'R') }