Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker improvments #47

Open
Tokariew opened this issue Apr 12, 2021 · 0 comments
Open

Docker improvments #47

Tokariew opened this issue Apr 12, 2021 · 0 comments

Comments

@Tokariew
Copy link

Tokariew commented Apr 12, 2021

System with selinux will fail to run docker command from readme. They require additional ":z" option in volume mount. The ":z" option shouldn't mess with system without selinux

So should look like this.

docker run -v $(PWD)/download:/download:z --rm -it dmarby/humblebundle-ebook-downloader -d /download --auth-token "auth_string_here"

I think _simpleauth_sess shouldn't be visible in command history, so it will be probably good to have option to pass it as environment variables with --env-file option. But this will require modifying program probably…

As this program don't require elevated privileges maybe it should be run with podman instead of docker, which don't require root, and it will not mess file permissions on linux. If it will stay docker it would be nice to add "-u" option from docker. Than files will no longer belong to root. This is probably unix only…

docker run -v $(PWD)/download:/download:z -u $(id -u) --rm -it dmarby/humblebundle-ebook-downloader -d /download --auth-token "auth_string_here"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant