Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new function for opaque data parsing. #2936

Open
jyao1 opened this issue Dec 19, 2024 · 0 comments
Open

add new function for opaque data parsing. #2936

jyao1 opened this issue Dec 19, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jyao1
Copy link
Member

jyao1 commented Dec 19, 2024

libspdm_get_element_from_opaque_data() will get first (element_id, and sm_data_id) pair. Although the name is generic, but it has assumption that element_id is DMTF, because sm_data_id is only under DMTF.

I suggest to define two functions: (just rough thought)

  • libspdm_get_element_from_opaque_data_with_element_id (element_id, element_index) - that is to get element with ID and index to support multiple elements.
  • libspdm_get_sm_data_element_from_opaque_data (sm_data_id) - that is to get SM_DATA only, with assumption that element_id is DMTF.

The first function can be used for SPDM 1.4 with DMTF-DSP, and support DSP0289 Authorization AODS.

  • libspdm_get_aods_element_from_opaque_data (aods_id) - that is to get AODS with assumption that element_id is DMTF-DSP in the future.

Ref: #2935 (comment)

@jyao1 jyao1 self-assigned this Dec 19, 2024
@steven-bellock steven-bellock added the enhancement New feature or request label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants