Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change source and sink methods so, that they use the Result type as a return value for most methods. #44

Open
dankwart-de opened this issue Sep 19, 2019 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@dankwart-de
Copy link
Contributor

Why? Because in the current implementation, the methods like readChar, read or write are very C/C++'ish and return e.g. -1, if "bad things happen". With the Return type, we can have a modern approach which
a) returns success or not
b) returns a result, if successful
c) can hold a message, describing the nature of the error.

@dankwart-de dankwart-de added enhancement New feature or request good first issue Good for newcomers labels Sep 19, 2019
@dankwart-de dankwart-de added this to the 1.0.0 milestone Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant