Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osm-install.sh is bad with dependencies #9

Open
oleks opened this issue Feb 16, 2016 · 9 comments
Open

osm-install.sh is bad with dependencies #9

oleks opened this issue Feb 16, 2016 · 9 comments

Comments

@oleks
Copy link
Member

oleks commented Feb 16, 2016

On Ubuntu, users should do this:
$ sudo apt-get install build-essential texinfo libgmp3-dev libmpfr-dev libmpc-dev

@nqpz
Copy link
Member

nqpz commented Feb 16, 2016

Actually, you can just run this:
$ sudo apt-get build-dep gcc binutils
The install script explicitly notes this in the comments.

@nqpz
Copy link
Member

nqpz commented Feb 16, 2016

Also, the script does run ./contrib/download_prerequisites, which should make sure that making gcc also makes the downloaded dependencies. However, it doesn't actually appear to be that way. The contrib script is very poorly documented...

@oleks
Copy link
Member Author

oleks commented Feb 16, 2016

On Tue, Feb 16, 2016 at 5:53 PM, Niels G. W. Serup
[email protected] wrote:

Also, the script does run ./contrib/download_prerequisites, which should make sure that making gcc also makes the downloaded dependencies. However, it doesn't actually appear to be that way. The contrib script is very poorly documented...

Yeah, that part doesn't seem to work.

@nqpz
Copy link
Member

nqpz commented Feb 16, 2016

On 2016-02-16 09:53:11, Oleks wrote:

On Tue, Feb 16, 2016 at 5:53 PM, Niels G. W. Serup
[email protected] wrote:

Also, the script does run ./contrib/download_prerequisites, which should make sure that making gcc also makes the downloaded dependencies. However, it doesn't actually appear to be that way. The contrib script is very poorly documented...

Yeah, that part doesn't seem to work.

But still, we can't assume that osm-install.sh is run somewhere with
apt-get. I like the current "solution" of just noting it on Piazza.

@oleks
Copy link
Member Author

oleks commented Feb 16, 2016

On Tue, Feb 16, 2016 at 5:51 PM, Niels G. W. Serup
[email protected] wrote:

Actually, you can just run this:
$ sudo apt-get build-dep gcc binutils

Cool, I think that should've been noted at the top of the file.
Students had a hard time understanding why the script didn't work.
What I suggested on Piazza worked for us, but I was also aware that it
was dirty.

All other things being equal, students do tend towards Ubuntu, so I
think Ubuntu installation instructions should be handed out and
dry-runs should happen in next iterations of mass MIPS32
cross-compiler installations.

Although, I do also tend towards containers in the very near future to
avoid this mess altogether.

@nqpz
Copy link
Member

nqpz commented Feb 16, 2016

On 2016-02-16 09:57:57, Oleks wrote:

On Tue, Feb 16, 2016 at 5:51 PM, Niels G. W. Serup
[email protected] wrote:

Actually, you can just run this:
$ sudo apt-get build-dep gcc binutils

Cool, I think that should've been noted at the top of the file.
Students had a hard time understanding why the script didn't work.
What I suggested on Piazza worked for us, but I was also aware that it
was dirty.

All other things being equal, students do tend towards Ubuntu, so I
think Ubuntu installation instructions should be handed out and
dry-runs should happen in next iterations of mass MIPS32
cross-compiler installations.

Yes, I agree that we should target the common OS, since the other
students have a higher chance of figuring it out on their own.

However, I would still like to note that the very first comment line
says "READ THIS SCRIPT BEFORE RUNNING IT!", so, well... But I digress.

@oleks
Copy link
Member Author

oleks commented Feb 16, 2016

On Tue, Feb 16, 2016 at 7:01 PM, Niels G. W. Serup
[email protected] wrote:

However, I would still like to note that the very first comment line
says "READ THIS SCRIPT BEFORE RUNNING IT!", so, well... But I digress.

Maybe we should hand it out as a non-executable txt and make students
rename it to a sh and mark it executable!

Students just assume that osm-install.sh does everything for them :-/

But yeah, once the dependencies were worked out, things worked out well.

@oleks oleks closed this as completed Feb 20, 2016
@oleks
Copy link
Member Author

oleks commented Feb 20, 2016

Okay, so I think the best solution for the future (short of containers) is to make osm-install.sh either non-executable to start with, or to print the aggressive intro-message when the script is run, and have the script check the availability of the dependencies before proceeding.

Containers are the cooler way to go though.

@oleks oleks reopened this Feb 20, 2016
@nqpz
Copy link
Member

nqpz commented Feb 20, 2016

On 2016-02-20 04:49:55, Oleks wrote:

Okay, so I think the best solution for the future (short of containers) is to make osm-install.sh either non-executable to start with, or to print the aggressive intro-message when the script is run, and have the script check the availability of the dependencies before proceeding.

Containers are the cooler way to go though.

I agree with both sentiments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants