Merge pull request #1241 from DFE-Digital/cshnimble-patch-2

Update Dockerfile to node 18.20.x
DFE-Digital · Jun 28, 2024 · bb61485 · bb61485
2 parents 40bbb1b + 73493b5
commit bb61485
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/.github/workflows/build-and-push-image.yml b/.github/workflows/build-and-push-image.yml
@@ -14,9 +14,6 @@ on:
 concurrency:
   group: ${{ github.workflow }}-${{ github.event.inputs.environment }}
 
-env:
-  NODE_VERSION: 16.x
-
 jobs:
   set-env:
     name: Determine environment

diff --git a/ConcernsCaseWork/ConcernsCaseWork/wwwroot/package.json b/ConcernsCaseWork/ConcernsCaseWork/wwwroot/package.json
@@ -1,6 +1,6 @@
 {
   "engines": {
-    "node": ">=14.0.0 <17.0.0"
+    "node": ">=18.0.0"
   },
   "scripts": {
     "build": "npm run build:assets && npm run build:frontend --env.NODE_ENV=production && npm run build:sass-migrator",

diff --git a/Dockerfile b/Dockerfile
@@ -1,6 +1,6 @@
 # Stage 1
 ARG ASPNET_IMAGE_TAG=8.0-bookworm-slim
-ARG NODEJS_IMAGE_TAG=16-bullseye
+ARG NODEJS_IMAGE_TAG=18.20-bullseye
 ARG COMMIT_SHA=not-set
 
 FROM mcr.microsoft.com/dotnet/sdk:8.0 AS publish