Optimised to use Cypress base actions #1246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stretch96
approved these changes
Dec 12, 2024
FahadDarw
approved these changes
Dec 12, 2024
dangood84
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the official Cypress image for running CI tests, instead of rolling our own.
The main advantage is cache of binaries (browsers) and packages are maintained upstream for us.
Using the cypress:browsers image also ensures we are pinned to a specific collection of browsers in case the GitHub runner updates it upstream.
I've added a browser matrix strategy too in case we want to run the same set of tests against multiple browsers in the future.
--
Successful GitHub Action run:
https://github.com/DFE-Digital/prepare-academy-conversions/actions/runs/12281760747