Add Key Vault Data Protection to dotnet #1076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrizzlyOwl
force-pushed
the
feat-data-protection
branch
3 times, most recently
from
6dcec87 to
7366805
Compare
This comment was marked as outdated.
This comment was marked as outdated.
DrizzlyOwl
force-pushed
the
feat-data-protection
branch
2 times, most recently
from
f7a5276 to
8ec8543
Compare
DrizzlyOwl
force-pushed
the
feat-data-protection
branch
from
8ec8543 to
a6a2de2
Compare
DrizzlyOwl
requested review from
Stretch96,
paullocknimble,
danielryannimble,
dangood84,
elielijah321,
FahadDarw and
mshakirdfe
as code owners
DrizzlyOwl
changed the title
|
mshakirdfe
approved these changes
Dec 3, 2024
Stretch96
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this Pull Request is to add aspnet Data Protection services to the webapp. This will ensure that user sessions are secured and persistent across multiple 'instances' of the web app. This is particularly important in Azure where the app is running in containers.
As you will see in the logic of the patch, this is not testable on a local machine due to requiring access to a linux file path and Azure Key Vault Key.
Mounting a network-attached File Share to all the containers that run the app, then storing the session key ring
key.xmlon the shared file path, will ensure all instances of the app can use the same key for encrypting/decrypting user sessions.Changes