Skip to content
Pull request checks

Merge pull request #1078 from DFE-Digital/feature/160874-dao-revoked #5604

Sign in to view logs

Merge pull request #1078 from DFE-Digital/feature/160874-dao-revoked

Merge pull request #1078 from DFE-Digital/feature/160874-dao-revoked #5604

Triggered via push June 4, 2024 15:24
@dneed-nimbledneed-nimble
pushed c8a8637
main
Status Failure
Total duration 3m 6s
Artifacts –

build.yml

on: push
lint
23s
lint
build
2m 57s
build
Fit to window
Zoom out
Zoom in

Annotations

1 error and 10 warnings
build
Process completed with exit code 1.
build: Dfe.PrepareConversions/Dfe.PrepareConversions.DocumentGeneration/Builders/TableBuilder.cs#L54
Define a constant instead of using this literal '000000' 6 times. (https://rules.sonarsource.com/csharp/RSPEC-1192)
build: Dfe.PrepareConversions/Dfe.PrepareConversions.DocumentGeneration/Helpers/HtmlToElements.cs#L72
Collection-specific "Exists" method should be used instead of the "Any" extension. (https://rules.sonarsource.com/csharp/RSPEC-6605)
build: Dfe.PrepareConversions/Dfe.PrepareConversions.DocumentGeneration/Builders/NumberedListBuilder.cs#L28
Review this call, which partially matches an overload without 'params'. The partial match is 'ParagraphProperties.ParagraphProperties(IEnumerable<OpenXmlElement> childElements)'. (https://rules.sonarsource.com/csharp/RSPEC-3220)
build: Dfe.PrepareConversions/Dfe.PrepareConversions.DocumentGeneration/Helpers/DocumentBuilderHelpers.cs#L24
Indexing at Count-1 should be used instead of the "Enumerable" extension method "Last" (https://rules.sonarsource.com/csharp/RSPEC-6608)
build: Dfe.PrepareConversions/Dfe.PrepareConversions.DocumentGeneration/Builders/BulletedListBuilder.cs#L28
Review this call, which partially matches an overload without 'params'. The partial match is 'ParagraphProperties.ParagraphProperties(IEnumerable<OpenXmlElement> childElements)'. (https://rules.sonarsource.com/csharp/RSPEC-3220)
build: Dfe.PrepareConversions/Dfe.PrepareConversions.DocumentGeneration/Builders/BulletedListBuilder.cs#L29
Review this call, which partially matches an overload without 'params'. The partial match is 'RunProperties.RunProperties(IEnumerable<OpenXmlElement> childElements)'. (https://rules.sonarsource.com/csharp/RSPEC-3220)
build: Dfe.PrepareConversions/Dfe.PrepareConversions.DocumentGeneration/DocumentBuilder.cs#L27
Review this call, which partially matches an overload without 'params'. The partial match is 'Document.Document(IEnumerable<OpenXmlElement> childElements)'. (https://rules.sonarsource.com/csharp/RSPEC-3220)
build: Dfe.PrepareConversions/Dfe.PrepareConversions.DocumentGeneration/DocumentBuilder.cs#L148
Review this call, which partially matches an overload without 'params'. The partial match is 'Settings.Settings(IEnumerable<OpenXmlElement> childElements)'. (https://rules.sonarsource.com/csharp/RSPEC-3220)
build: Dfe.PrepareConversions/Dfe.PrepareConversions.DocumentGeneration/DocumentBuilder.cs#L148
Review this call, which partially matches an overload without 'params'. The partial match is 'Compatibility.Compatibility(IEnumerable<OpenXmlElement> childElements)'. (https://rules.sonarsource.com/csharp/RSPEC-3220)
build: Dfe.PrepareConversions/Dfe.PrepareConversions.DocumentGeneration/DocumentBuilder.cs#L201
"Array.Find" static method should be used instead of the "FirstOrDefault" extension method. (https://rules.sonarsource.com/csharp/RSPEC-6602)