Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace terrafile #1489

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Replace terrafile #1489

merged 2 commits into from
Dec 2, 2024

Conversation

neillturner
Copy link
Contributor

@neillturner neillturner commented Nov 29, 2024

Context

Replace terrafile as it's not maintained anymore. Using simple git instead.

Changes proposed in this pull request

  • Update makefile to remove references to terrafile
  • Update makefile to add new vendor-modules target with git command to correct location for terraform code
  • In global_config directory add correct value for TERRAFORM_MODULES_TAG in config files
  • In terraform/application/config directory remove terrafile files
  • Update .gitignore remove bin/terrafile

NOTE: Had to suppress the end of support message for dotNET 7.0 in the dotNET build set to get the actions to complete

the developer Martyn Whitwell was alerted and his response is:

Updating the .NET version is likely to be quite a big job… I’ll add a ticket to our backlog to do this but its not likely to happen in the next few sprints. Could you add a bypass for now? Thanks

Guidance to review

i tested for each environment and to see terraform correctly get the module code
make test_aks terraform-plan IMAGE_TAG=xxxx
make development_aks terraform-plan IMAGE_TAG=xxxx
make production_aks terraform-plan IMAGE_TAG=xxxx

Link to Trello card

Replace terrafile

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@github-actions github-actions bot added the DevOps DevOps label Nov 29, 2024
@neillturner
Copy link
Contributor Author

Replace terrafile

Copy link

sonarcloud bot commented Nov 29, 2024

@neillturner neillturner merged commit f383ee1 into master Dec 2, 2024
12 checks passed
@neillturner neillturner deleted the replace-terrafile branch December 2, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps DevOps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants