Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[651] Fix git api build workflow #1303

Merged
merged 3 commits into from
Sep 19, 2023
Merged

[651] Fix git api build workflow #1303

merged 3 commits into from
Sep 19, 2023

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Sep 18, 2023 •
edited
Loading

What

Fix the workflow by removing dependencies on paas and old keyvault

How to review

See successful runs:

@saliceti saliceti added the DevOps DevOps label Sep 18, 2023
@saliceti saliceti force-pushed the 651-fix-git-api-build-workflow branch from c9c18e9 to 39efb37 Compare September 19, 2023 11:08
@saliceti
Remove paas workflow and action
7f3bfd6
@saliceti
Refactor workflows
6481c5c 
- Use new keyvault with separate secrets (not yaml)
- Remove extra production job from build-and-deploy (only done via
  Manual)
- Trigger on pull requests
- Update manual with AKS deployment
- Remove references to git api in fix-network-policy
@saliceti
Pin terraform to 1.4.6 with asdf
00e8dd5
@saliceti saliceti force-pushed the 651-fix-git-api-build-workflow branch from 39efb37 to 00e8dd5 Compare September 19, 2023 11:10
@saliceti saliceti marked this pull request as ready for review September 19, 2023 11:17
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@saliceti saliceti merged commit 01425f7 into master Sep 19, 2023
12 checks passed
@saliceti saliceti deleted the 651-fix-git-api-build-workflow branch September 19, 2023 11:24
@saliceti
Copy link
Member Author

Fix Git API build workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plisovin plisovin plisovin approved these changes

Assignees
No one assigned
Labels
DevOps DevOps
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saliceti @plisovin