[CAPT-1797] Ops reports spike #3284
Open
+293
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alkesh
force-pushed
the
CAPT-1797-monthly-reports
branch
from
d00e400 to
5247399
Compare
rjlynch
approved these changes
Oct 8, 2024
| ].freeze | ||
|
|
||
| def initialize | ||
| @claims = Claim.approved.select { |claim| Claim::MatchingAttributeFinder.new(claim).matching_claims.any? } |
There was a problem hiding this comment.
Suggested change
| @claims = Claim.approved.select { |claim| Claim::MatchingAttributeFinder.new(claim).matching_claims.any? } | |
| @claims = Claim.approved.includes(:eligibility).select { |claim| Claim::MatchingAttributeFinder.new(claim).matching_claims.any? } |
Not sure if we want to include decisions too or if it's less work to filter first and make the additional trips to the db
| ].freeze | ||
|
|
||
| def initialize | ||
| @claims = Claim.includes(:tasks) |
There was a problem hiding this comment.
Suggested change
| @claims = Claim.includes(:tasks) | |
| @claims = Claim.includes(:tasks, :eligibility) |
| ].freeze | ||
|
|
||
| def initialize | ||
| @claims = Claim.includes(:tasks).where(tasks: {name: "qualifications", passed: false}).approved |
There was a problem hiding this comment.
Suggested change
| @claims = Claim.includes(:tasks).where(tasks: {name: "qualifications", passed: false}).approved | |
| @claims = Claim.includes(:tasks, :eligibility).where(tasks: {name: "qualifications", passed: false}).approved |
| def change | ||
| create_table :reports, id: :uuid do |t| | ||
| t.string :name | ||
| t.text :csv |
There was a problem hiding this comment.
Nice approach 👍, very simple and gets the job done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Claim::DataReportRequestclass