Updated test to account for new isfam param

DFE-Digital · Apr 17, 2024 · f4cbe5a · f4cbe5a
1 parent 67ab0bf
commit f4cbe5a
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 33 deletions.
diff --git a/Dfe.Academies.Academisation.Domain/TransferProjectAggregate/TransferProject.cs b/Dfe.Academies.Academisation.Domain/TransferProjectAggregate/TransferProject.cs
@@ -34,7 +34,7 @@ protected TransferProject() { }
 
 		public string? ProjectReference { get; private set; }
 		public string OutgoingTrustUkprn { get; private set; }
-		public string? OutgoingTrustName{ get; private set; }
+		public string? OutgoingTrustName { get; private set; }
 		public string? WhoInitiatedTheTransfer { get; private set; }
 
 
@@ -94,7 +94,7 @@ protected TransferProject() { }
 		public IReadOnlyCollection<TransferringAcademy> TransferringAcademies => _transferringAcademies;
 
 		IReadOnlyCollection<IIntendedTransferBenefit> ITransferProject.IntendedTransferBenefits => _intendedTransferBenefits;
-		IReadOnlyCollection<ITransferringAcademy> ITransferProject.TransferringAcademies => 
+		IReadOnlyCollection<ITransferringAcademy> ITransferProject.TransferringAcademies =>
 			_transferringAcademies;
 
 		public DateTime? CreatedOn { get; private set; }
@@ -133,7 +133,7 @@ public void AssignUser(Guid userId, string userEmail, string userFullName)
 		}
 
 		public void SetFeatures(string whoInitiatedTheTransfer, List<string> specificReasonsForTransfer, string transferType, bool? isCompleted)
-		{	
+		{
 			WhoInitiatedTheTransfer = whoInitiatedTheTransfer;
 			_specificReasonsForTransfer = specificReasonsForTransfer;
 			TypeOfTransfer = transferType;
@@ -166,12 +166,12 @@ public void SetTransferringAcademiesSchoolData(string transferringAcademyUkprn,
 			);
 		}
 
-		public void SetBenefitsAndRisks(bool? anyRisks, bool? equalitiesImpactAssessmentConsidered, 
-			List<string> selectedBenefits, string? otherBenefitValue, 
-			bool? highProfileShouldBeConsidered, string? highProfileFurtherSpecification, 
-			bool? complexLandAndBuildingShouldBeConsidered, string? complexLandAndBuildingFurtherSpecification, 
-			bool? financeAndDebtShouldBeConsidered, string? financeAndDebtFurtherSpecification, 
-			bool? otherRisksShouldBeConsidered, string? otherRisksFurtherSpecification, 
+		public void SetBenefitsAndRisks(bool? anyRisks, bool? equalitiesImpactAssessmentConsidered,
+			List<string> selectedBenefits, string? otherBenefitValue,
+			bool? highProfileShouldBeConsidered, string? highProfileFurtherSpecification,
+			bool? complexLandAndBuildingShouldBeConsidered, string? complexLandAndBuildingFurtherSpecification,
+			bool? financeAndDebtShouldBeConsidered, string? financeAndDebtFurtherSpecification,
+			bool? otherRisksShouldBeConsidered, string? otherRisksFurtherSpecification,
 			bool? isCompleted)
 		{
 			AnyRisks = anyRisks;
@@ -182,7 +182,7 @@ public void SetBenefitsAndRisks(bool? anyRisks, bool? equalitiesImpactAssessment
 			OtherBenefitValue = otherBenefitValue;
 
 			HighProfileShouldBeConsidered = highProfileShouldBeConsidered;
-            HighProfileFurtherSpecification = highProfileFurtherSpecification;
+			HighProfileFurtherSpecification = highProfileFurtherSpecification;
 			ComplexLandAndBuildingShouldBeConsidered = complexLandAndBuildingShouldBeConsidered;
 			ComplexLandAndBuildingFurtherSpecification = complexLandAndBuildingFurtherSpecification;
 			FinanceAndDebtShouldBeConsidered = financeAndDebtShouldBeConsidered;
@@ -219,7 +219,8 @@ public void SetAcademyIncomingTrustName(int academyId, string incomingTrustName)
 			var transferringAcademy =
 						TransferringAcademies.SingleOrDefault(x => x.Id == academyId);
 
-			if (transferringAcademy != null) {
+			if (transferringAcademy != null)
+			{
 
 				transferringAcademy.SetIncomingTrustName(incomingTrustName);
 

diff --git a/Dfe.Academies.Academisation.Service.UnitTest/Queries/TransferProjectQueryServiceTests.cs b/Dfe.Academies.Academisation.Service.UnitTest/Queries/TransferProjectQueryServiceTests.cs
@@ -35,16 +35,16 @@ public async Task GetByUrn_ShouldReturnExpectedResponse()
 			var dummyUrn = 1;
 
 
-		// Create a TransferProject
-		ITransferProject dummyTransferProject = TransferProject.Create(
-			"dummyOutgoingTrustUkprn",
-			"out trust",
-			"dummyIncomingTrustUkprn",
-			"in trust",
-			new List<string> { "dummyUkprn1", "dummyUkprn2" },
-			false,
-			DateTime.Now
-		);
+			// Create a TransferProject
+			ITransferProject dummyTransferProject = TransferProject.Create(
+				"dummyOutgoingTrustUkprn",
+				"out trust",
+				"dummyIncomingTrustUkprn",
+				"in trust",
+				new List<string> { "dummyUkprn1", "dummyUkprn2" },
+				false,
+				DateTime.Now
+			);
 
 
 			// Mock the setup to return the dummy project
@@ -71,16 +71,16 @@ public async Task GetById_ShouldReturnExpectedResponse()
 			var dummyId = 1;
 
 
-		// Create a TransferProject
-		var dummyTransferProject = TransferProject.Create(
-			"dummyOutgoingTrustUkprn",
-			"out trust",
-			"dummyIncomingTrustUkprn",
-			"in trust",
-			new List<string> { "dummyUkprn1", "dummyUkprn2" },
-			false,
-			DateTime.Now
-		);
+			// Create a TransferProject
+			var dummyTransferProject = TransferProject.Create(
+				"dummyOutgoingTrustUkprn",
+				"out trust",
+				"dummyIncomingTrustUkprn",
+				"in trust",
+				new List<string> { "dummyUkprn1", "dummyUkprn2" },
+				false,
+				DateTime.Now
+			);
 
 			// Mock the setup to return the dummy project
 			mockRepository.Setup(repo => repo.GetById(It.IsAny<int>())).Returns(Task.FromResult(dummyTransferProject));
@@ -268,8 +268,8 @@ public async Task GetProjects_ReturnsFilteredProjects()
 			// Sample data setup
 			var dummyProjects = new List<TransferProject>
 	{
-		TransferProject.Create("outUkprn1", "Out Trust 1", "inUkprn1", "In Trust 1", new List<string> { "ukprn1" }, DateTime.UtcNow),
-		TransferProject.Create("outUkprn2", "Out Trust 2", "inUkprn2", "In Trust 2", new List<string> { "ukprn2" }, DateTime.UtcNow)
+		TransferProject.Create("outUkprn1", "Out Trust 1", "inUkprn1", "In Trust 1", new List<string> { "ukprn1" },false, DateTime.UtcNow),
+		TransferProject.Create("outUkprn2", "Out Trust 2", "inUkprn2", "In Trust 2", new List<string> { "ukprn2" },false, DateTime.UtcNow)
 	};
 
 			// Expected data setup