We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
don't use absolute path, use relative one
ASD_Labs/Matrix/Matrix/Matrix.cpp
Line 3 in dbe072c
Line 12 in dbe072c
Line 15 in dbe072c
Line 16 in dbe072c
Line 18 in dbe072c
Line 22 in dbe072c
Line 27 in dbe072c
Line 47 in dbe072c
Line 96 in dbe072c
Line 189 in dbe072c
Line 194 in dbe072c
Line 287 in dbe072c
The text was updated successfully, but these errors were encountered:
decided approach is too complex *(
Sorry, something went wrong.
No branches or pull requests
don't use absolute path, use relative one
ASD_Labs/Matrix/Matrix/Matrix.cpp
Line 3 in dbe072c
don't use default values in public invocations, move fishy assignment to body, nullptr is strange why not empty array, "{" to new line
ASD_Labs/Matrix/Matrix/Matrix.cpp
Line 12 in dbe072c
rows are not initialized, is it supposed to be so?
ASD_Labs/Matrix/Matrix/Matrix.cpp
Line 15 in dbe072c
instead of size_t use auto keyword (will be automaticaly adjust to int type)
ASD_Labs/Matrix/Matrix/Matrix.cpp
Line 16 in dbe072c
"{" to new line
ASD_Labs/Matrix/Matrix/Matrix.cpp
Line 18 in dbe072c
"{" to new line
ASD_Labs/Matrix/Matrix/Matrix.cpp
Line 22 in dbe072c
remove if not used
ASD_Labs/Matrix/Matrix/Matrix.cpp
Line 27 in dbe072c
add brackets
ASD_Labs/Matrix/Matrix/Matrix.cpp
Line 27 in dbe072c
logic with that one is too complex, it can be simplified
ASD_Labs/Matrix/Matrix/Matrix.cpp
Line 47 in dbe072c
just return second element here, at the end return 0, int* element can be removed
ASD_Labs/Matrix/Matrix/Matrix.cpp
Line 96 in dbe072c
prefer to use _n, _m
ASD_Labs/Matrix/Matrix/Matrix.cpp
Line 189 in dbe072c
Unit test should test 1 item at a time, divide those to separate tests
ASD_Labs/Matrix/Matrix/Matrix.cpp
Line 194 in dbe072c
bad practice to assign elemnts inside function invocation
ASD_Labs/Matrix/Matrix/Matrix.cpp
Line 287 in dbe072c
The text was updated successfully, but these errors were encountered: