Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brain_radius hardcoded to 50 #17

Closed
arueter1 opened this issue Sep 2, 2021 · 3 comments
Closed

brain_radius hardcoded to 50 #17

arueter1 opened this issue Sep 2, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@arueter1
Copy link

arueter1 commented Sep 2, 2021

Luci noticed that brain_radius appears to be hardcoded as 50 in a few places in DCANBOLDProc. For infant processing, we set brain_radius to 45 and it appears as though DBP overrides this because the FD values output by the pipeline match the values calculated using 50 mm. It would be nice if we could change the code to not override the input brain_radius so we could use this piece of code on infants.

@arueter1 arueter1 added the enhancement New feature or request label Sep 2, 2021
@arueter1 arueter1 assigned perronea and unassigned ericfeczko Sep 14, 2021
@LuciMoore
Copy link
Contributor

I took a closer look and it appears as though this is no longer an issue if it ever was, I may have been mistaken in my observation

@madisoth madisoth assigned madisoth and unassigned perronea Sep 24, 2024
@madisoth madisoth reopened this Sep 24, 2024
@madisoth
Copy link
Collaborator

Reopening this issue; as noted in #28, brain_radius in dcan_bold_proc.py is not being passed to dcan_signal_processing and filtered_movement_regressors.

New PR (#29) is up to address this.

Quick FD comparison using infant-abcd-bids-pipeline (which passes in a brain radius = 45 mm to dcan_bold_proc.py)

Using DBP v4.0.13:
dbp_4013

Using PR #29:
dbp_test

@LuciMoore
Copy link
Contributor

addressed by PR #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants