Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize functions in SynthSeg/dcan/paper/*.py scripts (from code review) #3

Open
GregConan opened this issue Feb 17, 2022 · 0 comments

Comments

@GregConan
Copy link
Member

Reorganize and centralize the Python functions currently in multiple scripts located in the SynthSeg/dcan/paper/ directory. Changes suggested during the code review on 2022-02-09:

  • There's no reason to keep all of these functions in separate script files, so all of the subsidiary functions should be moved into the top-level Python script file (the one with a main() function)
  • Make the different functions different stages that the user could choose to run via an argparse flag
  • Pull the measures variable up to the top level because it is used across multiple scripts/functions
  • Make an argparse argument/flag for that measures variable which includes all 5 of them by default, but can be limited to only run some of them
@GregConan GregConan changed the title Reorganize functions in SynthSeg/dcan/paper/*.py scripts (from code review) Reorganize functions in SynthSeg/dcan/paper/*.py scripts (from code review) Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant