Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change hardcoded MSI paths in SynthSeg/dcan/paper/*.py scripts (from code review) #2

Open
GregConan opened this issue Feb 17, 2022 · 0 comments

Comments

@GregConan
Copy link
Member

Hardcoded MSI paths suggested to change in the Python scripts located in the SynthSeg/dcan/paper/ directory, all suggested during the code review on 2022-02-09:

In General

  • Replace hardcoded MSI paths with input arguments that the user can change

Change hardcoded MSI paths in specific Python scripts

(Scripts in the SynthSeg/dcan/paper/ directory)

generate_metrics.py

  • Currently, results_dir is hardcoded
    • To make this script reproducible on different systems, it should just be a hardcoded default option in an argparse parser

create_plots.py

  • Change the hardcoded relative path to {measure}.png on line 18 to an input arguments (possibly with a hardcoded default)
@GregConan GregConan changed the title Change hardcoded MSI paths in SynthSeg/dcan/paper/*.py scripts (from code review) Change hardcoded MSI paths in SynthSeg/dcan/paper/*.py scripts (from code review) Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant