You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hardcoded MSI paths suggested to change in the Python scripts located in the SynthSeg/dcan/paper/ directory, all suggested during the code review on 2022-02-09:
In General
Replace hardcoded MSI paths with input arguments that the user can change
Change hardcoded MSI paths in specific Python scripts
(Scripts in the SynthSeg/dcan/paper/ directory)
generate_metrics.py
Currently, results_dir is hardcoded
To make this script reproducible on different systems, it should just be a hardcoded default option in an argparse parser
create_plots.py
Change the hardcoded relative path to {measure}.png on line 18 to an input arguments (possibly with a hardcoded default)
The text was updated successfully, but these errors were encountered:
GregConan
changed the title
Change hardcoded MSI paths in SynthSeg/dcan/paper/*.py scripts (from code review)
Change hardcoded MSI paths in SynthSeg/dcan/paper/*.py scripts (from code review)
Feb 17, 2022
Hardcoded MSI paths suggested to change in the Python scripts located in the
SynthSeg/dcan/paper/
directory, all suggested during the code review on 2022-02-09:In General
Change hardcoded MSI paths in specific Python scripts
(Scripts in the
SynthSeg/dcan/paper/
directory)generate_metrics.py
results_dir
is hardcodedargparse
parsercreate_plots.py
The text was updated successfully, but these errors were encountered: