Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

fix blocking call in event loop, and add dev/test tooling #9

Merged
merged 3 commits into from
May 6, 2024
Merged

fix blocking call in event loop, and add dev/test tooling #9

merged 3 commits into from
May 6, 2024

Conversation

attilaersek
Copy link
Collaborator

Hey!

First of all, I'd like to thank all your efforts you've put into resurrecting this project! I was worried that this integration is not maintained anymore, I hope you'll accept my very first contribution.
I'm not a python developer (at all!) and I'm definitely not a HomeAssistant custom integration developer, so please triple test everything. I do my best to test my changes!

What's included:

and a special commit that bumps versions and changes the component owner to you, @CyrielRct !

Let me know if you'd like to change something.

@attilaersek
Copy link
Collaborator Author

Can you exclude the following folders for now?

  • .devcontainer
  • .vscode
    I will update the .gitignore to ignore .vscode and such

Yes, I can revert the developer tooling if you wish. Though it could simplify contributors life.

I'll push the change tomorrow!

Are you happy with the rest of the changes?

@Qianli-Ma
Copy link
Collaborator

Can you exclude the following folders for now?

  • .devcontainer
  • .vscode
    I will update the .gitignore to ignore .vscode and such

Yes, I can revert the developer tooling if you wish. Though it could simplify contributors life.

I'll push the change tomorrow!

Are you happy with the rest of the changes?

On second thought, I believe that you are correct. Let's keep the developer tooling.

@Qianli-Ma Qianli-Ma merged commit 30cf2f1 into CyrielRct:master May 6, 2024
@attilaersek
Copy link
Collaborator Author

Can you exclude the following folders for now?

  • .devcontainer
  • .vscode
    I will update the .gitignore to ignore .vscode and such

Yes, I can revert the developer tooling if you wish. Though it could simplify contributors life.

I'll push the change tomorrow!

Are you happy with the rest of the changes?

On second thought, I believe that you are correct. Let's keep the developer tooling.

Appreciate your quick response and openness! Let me know if I can help somehow!

@attilaersek attilaersek linked an issue May 13, 2024 that may be closed by this pull request
Detected blocking call to import_module inside the event loop #7
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Qianli-Ma Qianli-Ma Qianli-Ma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detected blocking call to import_module inside the event loop
2 participants
@attilaersek @Qianli-Ma