Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis with GitHub Actions CI #69

Merged
merged 1 commit into from
Jun 20, 2021
Merged

Replace Travis with GitHub Actions CI #69

merged 1 commit into from
Jun 20, 2021

Conversation

Margen67
Copy link
Member

@Margen67 Margen67 commented Apr 1, 2021

No description provided.

@Margen67 Margen67 marked this pull request as ready for review April 1, 2021 12:05
@Margen67 Margen67 changed the title GitHub Actions CI Add GitHub Actions CI Apr 1, 2021
@Luca1991
Copy link
Member

Luca1991 commented Apr 1, 2021

Awesome! if this is working, it is a great replacement for Travis.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@RadWolfie
Copy link
Member

RadWolfie commented Apr 1, 2021

While having Github's Actions put into use internally is great thing to have. I can foreseen side effect if I, approved, merge this of duplicate releases.

There are few of review remarks that need some changes at the moment.

@Margen67
Copy link
Member Author

Margen67 commented Apr 1, 2021

While having Github's Actions put into use internally is great thing to have. I can foreseen side effect if I, approved, merge this of duplicate releases.

There are few of review remarks that need some changes at the moment.

The only way(s) to fix that are:

  1. Comment out Travis' deploy.
    2. Remove Travis completely. done

@Luca1991
Copy link
Member

Luca1991 commented Apr 1, 2021

I think we can remove Travis deploy, as GitHub Actions is actually more integrated and better.

@Margen67 Margen67 marked this pull request as draft May 8, 2021 12:27
@Margen67 Margen67 requested a review from RadWolfie May 27, 2021 21:29
@Margen67 Margen67 marked this pull request as ready for review May 28, 2021 18:41
.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@Margen67 Margen67 changed the title Add GitHub Actions CI Replace Travis with GitHub Actions CI Jun 20, 2021
@Margen67 Margen67 requested a review from RadWolfie June 20, 2021 01:59
@Margen67
Copy link
Member Author

Margen67 commented Jun 20, 2021

Travis is broken and isn't free anymore so I've removed it.

@RadWolfie RadWolfie merged commit ce47b08 into Cxbx-Reloaded:master Jun 20, 2021
@Margen67 Margen67 deleted the actions branch June 20, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants