Skip to content
This repository has been archived by the owner on Apr 3, 2022. It is now read-only.

Why do we have a makefile #13

Open
stevenruidigao opened this issue Jun 10, 2021 · 10 comments
Open

Why do we have a makefile #13

stevenruidigao opened this issue Jun 10, 2021 · 10 comments

Comments

@stevenruidigao
Copy link
Member

Firstly, why do we have a makefile?
Secondly, we forgot to tell people to install nodejs.

@ghost
Copy link

ghost commented Jun 10, 2021

The makefile is there to facilitate a uniform install process across all platforms supporting make.

EDIT: nobody wants to have to cd cli && node cli.js to use an app: the shellscript and makefile solve this.

@stevenruidigao
Copy link
Member Author

The makefile is there to facilitate a uniform install process across all platforms supporting make.

EDIT: nobody wants to have to cd cli && node cli.js to use an app: the shellscript and makefile solve this.

use regular shellscripts then
why use makefiles?

@ghost
Copy link

ghost commented Jun 11, 2021

The makefile moves the shellscript/launcher to /usr/local/bin, which is in your $PATH, and moves the actual js and node modules to /var/lib/cryptochat. this is meant to clean up usage of the app, only requiring the user to interact with the shellscript. did you read the makefile or are you just complaining that it's there?

@stevenruidigao
Copy link
Member Author

stevenruidigao commented Jun 11, 2021

Why aren't we just using a shellscript to install instead of a makefile?

@ghost
Copy link

ghost commented Jun 11, 2021

what's wrong with using make?

@stevenruidigao
Copy link
Member Author

stevenruidigao commented Jun 11, 2021 via email

@ghost
Copy link

ghost commented Jun 11, 2021

Simpler? Not really. Pointless? Maybe, but it works fine.

@stevenruidigao
Copy link
Member Author

also, btw here's a bundled version for amd64 (linux): https://filen.io/d/126874fd-f831-4de9-9791-9e26ae2c9f65#!vCLxQytP6b1CNJbYYpkrvfIERYbB1bua

@stevenruidigao
Copy link
Member Author

stevenruidigao commented Jun 11, 2021

Simpler? Not really. Pointless? Maybe, but it works fine.

I mean, it at least would remove the dependency on make, but idk.
make is mostly designed for compiling programs, but w/e.

@ghost
Copy link

ghost commented Jun 11, 2021

yeah that's the only thing i can think of, and it's a good point. maybe i can make an interactive installer in bash?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant