You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The condalock action fails silently, so if a test is fixed to pass, the PR checks pass and allow merging even if the conda-lock.yml has not been updated. The /condalock action must be re-triggered to run, and should be required to pass before merging is allowed.
The text was updated successfully, but these errors were encountered:
Thanks @JessicaS11 for opening this issue and adding the note at c65efc7 about checking the Actions tab. I'm hoping that turning the /condalock into a standalone command (#18) would allow us to enable this check under the 'Checks' tab of a PR, rather than someone having to jump to the Actions tab.
In the meantime, this 'check' will unfortunately need to fall on the Pull Request reviewer 🙂
From what I can tell after working a bit on #88, it won't be possible to enable a check under the 'Checks' tab with a slash command like /condalock because it uses workflow_dispatch or issue_comment triggers.
Instead, we would need to use either the pull_request, pull_request_target, or pull_request_review target (similar to the UML diagram update check on icepyx in icesat2py/icepyx#208). How about we forego having to write /condalock directly, and just use a pull_request_target based GitHub Action workflow to automatically regenerate lockfiles (when certain files like environment.yml has changed)? This would be similar to how some automatic linters work, and means that we can see what is happening in the 'Checks' tab instead of having to manually go over to the 'Actions' tab to see whether the lockfile has been re-generated.
The condalock action fails silently, so if a test is fixed to pass, the PR checks pass and allow merging even if the conda-lock.yml has not been updated. The
/condalock
action must be re-triggered to run, and should be required to pass before merging is allowed.The text was updated successfully, but these errors were encountered: