From 608d8b3aa1892dff66d9aad5e531caf59d2f7c50 Mon Sep 17 00:00:00 2001 From: Carlos Matos Date: Thu, 14 Sep 2023 13:06:37 -0400 Subject: [PATCH 1/3] fix: python3 check should check for pip3 instead of pip --- benchmark.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/benchmark.sh b/benchmark.sh index fcafb23..f1b10ad 100755 --- a/benchmark.sh +++ b/benchmark.sh @@ -25,7 +25,7 @@ check_python3() { echo "Python3 not found. Please install Python3 and try again." exit 1 fi - if ! type pip >/dev/null 2>&1; then + if ! type pip3 >/dev/null 2>&1; then echo "Pip not found. Please install pip and try again." exit 1 fi From eff5f507090069fd9113c0739850dcf5c960f7d8 Mon Sep 17 00:00:00 2001 From: Carlos Matos Date: Thu, 14 Sep 2023 13:07:04 -0400 Subject: [PATCH 2/3] docs: use correct project for consistency --- AWS/README.md | 2 +- Azure/README.md | 2 +- GCP/README.md | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/AWS/README.md b/AWS/README.md index 8f2bdc5..09fbbf2 100644 --- a/AWS/README.md +++ b/AWS/README.md @@ -21,7 +21,7 @@ Open AWS Cloud Shell ([overview](https://aws.amazon.com/cloudshell/), [documenta ### Run the script ```shell -curl https://raw.githubusercontent.com/CrowdStrike/Cloud-Benchmark/main/benchmark.sh | /bin/bash +curl https://raw.githubusercontent.com/CrowdStrike/cloud-resource-estimator/main/benchmark.sh | bash ``` ### Collect the findings diff --git a/Azure/README.md b/Azure/README.md index 1c4d5b0..ce66131 100644 --- a/Azure/README.md +++ b/Azure/README.md @@ -13,7 +13,7 @@ No changes will be made to your account. No data will be sent anywhere and will ### Run the script ```shell -curl https://raw.githubusercontent.com/CrowdStrike/Cloud-Benchmark/main/benchmark.sh | /bin/bash +curl https://raw.githubusercontent.com/CrowdStrike/cloud-resource-estimator/main/benchmark.sh | bash ``` ### Collect the findings diff --git a/GCP/README.md b/GCP/README.md index adf93c6..a2ffff1 100644 --- a/GCP/README.md +++ b/GCP/README.md @@ -8,12 +8,12 @@ No changes will be made to your account. No data will be sent anywhere and will ### Initialize execution environment -[![Open GCP Cloud Shell](https://gstatic.com/cloudssh/images/open-btn.svg)](https://shell.cloud.google.com/cloudshell/editor?cloudshell_git_repo=https%3A%2F%2Fgithub.com%2FCrowdStrike%2FCloud-Benchmark) +[![Open GCP Cloud Shell](https://gstatic.com/cloudssh/images/open-btn.svg)](https://shell.cloud.google.com/cloudshell/editor?cloudshell_git_repo=https%3A%2F%2Fgithub.com%2FCrowdStrike%2Fcloud-resource-estimator) ### Run the script ```shell -./benchmark.sh +bash benchmark.sh ``` ### Collect the findings From 1b96229d004cc1d5c28aaa50b7024fd91c3dc7ef Mon Sep 17 00:00:00 2001 From: Carlos Matos Date: Thu, 14 Sep 2023 13:13:18 -0400 Subject: [PATCH 3/3] revert the execution of the script in gcp readme --- GCP/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/GCP/README.md b/GCP/README.md index a2ffff1..88c9cc2 100644 --- a/GCP/README.md +++ b/GCP/README.md @@ -13,7 +13,7 @@ No changes will be made to your account. No data will be sent anywhere and will ### Run the script ```shell -bash benchmark.sh +./benchmark.sh ``` ### Collect the findings