Increase iteration cap for expressionConverge, add more informative print statements #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_sim_data_1.py. Increased iteration cap from 100 to 300, which seems to solve problems with occassional slow convergence on my laptop.
|
Confirmed that ParCa runs fine for me with this fix. Only changes are it will occassionally be a bit slower (instead of crashing). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional ParCa info for the expressionConverge function in fit_sim_data_1.py. Increased iteration cap from 100 to 300, which seems to solve problems with occassional slow convergence for certain cases on my laptop. Usually converges in 3-5 steps, but sometimes will take >100.