Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't catch overly broad Exception #22

Open
1fish2 opened this issue Nov 26, 2019 · 0 comments
Open

Don't catch overly broad Exception #22

1fish2 opened this issue Nov 26, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@1fish2
Copy link
Collaborator

1fish2 commented Nov 26, 2019

In Gaia and Sisyphus, catch narrow exceptions like IOException and JSON parser exceptions, not broad Exception (which will hide problems that need debugging like memory problems, esp. when the code doesn't log the exception).

@1fish2 1fish2 added the bug Something isn't working label Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant