Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[map] [mobile] add new list view of users on map #4848

Open
bakeiro opened this issue Sep 17, 2024 · 4 comments · May be fixed by #5294
Open

[map] [mobile] add new list view of users on map #4848

bakeiro opened this issue Sep 17, 2024 · 4 comments · May be fixed by #5294
Assignees
@marco-digennaro @bakeiro
Labels
3.skill good first issue
Milestone
Map V2

Comments

@bakeiro
Copy link
Contributor

bakeiro commented Sep 17, 2024 •
edited
Loading

Current:
image

Desired situation
image

Notes:
image
@bakeiro bakeiro added this to the Map V2 milestone Sep 17, 2024
@bakeiro bakeiro self-assigned this Sep 30, 2024
@bakeiro bakeiro changed the title [map] [mobile] add pagination like airbnb [map] [mobile] add new users list view Oct 4, 2024
@bakeiro bakeiro removed their assignment Oct 29, 2024
@jesseallhands jesseallhands changed the title [map] [mobile] add new users list view [map] [mobile] add new list view of users on map Nov 15, 2024
@marco-digennaro marco-digennaro self-assigned this Nov 24, 2024
@marco-digennaro
Copy link
Contributor

@bakeiro the list should scroll when it's closed? or it should show only the first result?

Screenshot 2024-11-27 at 20 51 47

@bakeiro
Copy link
Contributor Author

bakeiro commented Nov 28, 2024

@bakeiro the list should scroll when it's closed? or it should show only the first result?

Screenshot 2024-11-27 at 20 51 47

that's actually a good question... I think scrollable it's better ;)

@marco-digennaro
Copy link
Contributor

that's actually a good question... I think scrollable it's better ;)

x or y?

@bakeiro
Copy link
Contributor Author

bakeiro commented Nov 30, 2024 •
edited
Loading

that's actually a good question... I think scrollable it's better ;)

x or y?

Y please :)

[X is right now, (which IMHO is weird) plus I think will be confusing for users to have x while it's minimized, and Y while is open, so always Y I think it's better :) ]

marco-digennaro added a commit that referenced this issue Dec 4, 2024
@marco-digennaro
frontend - feat: add new list view of users on map #4848
0b1bab0
@nabramow nabramow linked a pull request Dec 8, 2024 that will close this issue
frontend - feat: add new list view of users on map #4848 #5294
Open
5 tasks
@nabramow nabramow linked a pull request Dec 8, 2024 that will close this issue
Open
5 tasks
@nabramow nabramow moved this from In Progress to PR in Couchers Engineering 💻 Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marco-digennaro marco-digennaro

@bakeiro bakeiro

Labels
3.skill good first issue
Projects
Couchers Engineering 💻
Status: PR
Milestone
Map V2
Development

Successfully merging a pull request may close this issue.

frontend - feat: add new list view of users on map #4848 Couchers-org/couchers
2 participants
@marco-digennaro @bakeiro