Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search doesn't present a list of hosts / search function on mobile is broken #5091

Closed
CouchersBot opened this issue Nov 3, 2024 · 7 comments · Fixed by #5225
Closed

Search doesn't present a list of hosts / search function on mobile is broken #5091

CouchersBot opened this issue Nov 3, 2024 · 7 comments · Fixed by #5225
Assignees
Labels
0.kind bug report This shouldn't be happening. 1.topic frontend bug tool User reported with bug reporting tool. critical issue Something is broken and is resulting in major usability issues
Milestone

Comments

@CouchersBot
Copy link
Member

Subject: Search doesn't present a list of hosts
Description:
Search for any city

Results:
You only see a map with a bunch of icons for hosts, but you do not see any hosts. You have to click on each icon after zooming in in order to see hosts.

Backend version: develop-7618e865
Frontend version: develop-7618e865
User Agent: Mozilla/5.0 (iPhone; CPU iPhone OS 18_1 like Mac OS X) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/18.1 Mobile/15E148 Safari/604.1
Page: https://couchers.org/search?location=New+York%2C+New+York%2C+United+States&hostingStatusOptions=2&hostingStatusOptions=3&bbox=-73.7002330&bbox=40.9176300&bbox=-74.2588430&bbox=40.4765780#loc=8.88/40.6975/-73.9795
User: brooklyngarson (12838)

@dickorydock
Copy link

Note that this only seems to happen on mobile devices. I was able to replicate on a computer browser by reducing the width to 959px.

@aapeliv aapeliv added 0.kind bug report This shouldn't be happening. 1.topic frontend labels Nov 12, 2024
@jesseallhands jesseallhands added the critical issue Something is broken and is resulting in major usability issues label Nov 24, 2024
@jesseallhands jesseallhands added this to the Map V2 milestone Nov 24, 2024
@jesseallhands
Copy link
Contributor

jesseallhands commented Nov 24, 2024

In addition to the search results not being shown, using map search is completely broken unless you do the "pinch to zoom" method and manually search. Using the filters does not work at all:

Screen_Recording_20241124_155059_Firefox.mp4

Users who don't do the "pinch to zoom" method to hunt for users on the platform will think that we don't have users and/or that our search is broken. This also aligns with the relatively high number of people who delete their account because of the reason "no users on the platform" or similar.

@jesseallhands jesseallhands changed the title Search doesn't present a list of hosts Search doesn't present a list of hosts / search function on mobile is broken Nov 24, 2024
@dickorydock
Copy link

Just adding that this used to work fine on mobile (likely 1-2 months ago, unsure exactly when it changed) with search results appearing in a left-right scrollable area at the bottom of the mobile screen. On desktop, results (still) appear to the left side of the screen.

@nabramow nabramow self-assigned this Nov 24, 2024
@nabramow nabramow moved this from Ready to In Progress in Couchers Engineering 💻 Nov 25, 2024
@dickorydock
Copy link

@nabramow could you upload screenshots documenting this fix? I still do not see hosts appearing where I do a search. Here is what I see. Should I open a new issue if this persists?
Uploading IMG_8509.png…

@jesseallhands
Copy link
Contributor

@dickorydock This PR has been merged but not yet deployed. You will see the fix once deployed to prod (the live website).

@nabramow nabramow moved this from PR to Done in Couchers Engineering 💻 Nov 25, 2024
@dickorydock
Copy link

dickorydock commented Dec 24, 2024

This issue on mobile is only partly resolved: when you first search a city no hosts appear until you click the "Search in this area" button. Until then, there's just an empty box at the bottom of the screen. @jesseallhands @nabramow let me know if I should make a new issue since this one has been closed

@nabramow
Copy link
Collaborator

This issue on mobile is only partly resolved: when you first search a city no hosts appear until you click the "Search in this area" button. Until then, there's just an empty box at the bottom of the screen. @jesseallhands @nabramow let me know if I should make a new issue since this one has been closed

I believe this issue will be addressed by a PR currently in review: #5294 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.kind bug report This shouldn't be happening. 1.topic frontend bug tool User reported with bug reporting tool. critical issue Something is broken and is resulting in major usability issues
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants