Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty discussion posts in events and communities are allowed #4172

Open
jesseallhands opened this issue Sep 24, 2021 · 5 comments · May be fixed by #5073
Open

Empty discussion posts in events and communities are allowed #4172

jesseallhands opened this issue Sep 24, 2021 · 5 comments · May be fixed by #5073
Assignees
@katemoser
Labels
0.kind bug report This shouldn't be happening. 1.topic backend This issue relates to the python backend 1.topic frontend 3.skill good first issue good value Solving this issue requires small effort compared to the benefit of closing it
Milestone
Bugs

Comments

@jesseallhands
Copy link
Contributor

jesseallhands commented Sep 24, 2021 •
edited
Loading

It is currently possible to submit an empty comment in community and event discussion threads:

image

You should not be able to post a comment if it is empty or only contains   or other nonvisible characters. Reddit has a simple solution to this with an error text:

image

I don't really like reddit's wording; I think something like "You need to type something first!" is a bit more clear.
@jesseallhands jesseallhands added 0.kind bug report This shouldn't be happening. 3.skill good first issue priority: normal good value Solving this issue requires small effort compared to the benefit of closing it labels Sep 24, 2021
@lucaslcode lucaslcode added the 1.topic backend This issue relates to the python backend label Sep 24, 2021
@lucaslcode
Copy link
Member

lucaslcode commented Sep 24, 2021 •
edited
Loading

This should be validated in backend and frontends

@aapeliv aapeliv changed the title Discussion posts in events and communities are allowed Empty discussion posts in events and communities are allowed Oct 14, 2021
@AlexVCS
Copy link
Contributor

AlexVCS commented Jan 13, 2022

I'd like to take on this task. Please assign it to me :)

@lucaslcode
Copy link
Member

@AlexVCS great! Let me know if you have any questions

@jesseallhands jesseallhands mentioned this issue Jan 19, 2022
Closed
@AlexVCS
Copy link
Contributor

AlexVCS commented Jan 24, 2022

Hi, sorry for the delay but I'm working on this issue now. I've looked throughout the codebase to try and see which files I should be targeting to work on this issue. I'm not sure which ones would lead me in the right direction. Can you point me in the right direction please? Thanks

@AndrewFarley AndrewFarley transferred this issue from Couchers-org/couchers Jun 2, 2022
@aapeliv aapeliv transferred this issue from Couchers-org/web-frontend Apr 20, 2024
@katemoser katemoser self-assigned this Oct 15, 2024
@bakeiro bakeiro added this to the Bugs milestone Oct 15, 2024
@katemoser katemoser linked a pull request Oct 28, 2024 that will close this issue
Open
13 tasks
@nabramow nabramow moved this to In Progress in Couchers Engineering 💻 Nov 9, 2024
@nabramow nabramow linked a pull request Nov 13, 2024 that will close this issue
fix empty discussion post in events communities #5073
Open
13 tasks
@nabramow
Copy link
Collaborator

Hey @katemoser just checking in with this, are you still working on it? Let me know if you need any help or have any questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@katemoser katemoser

Labels
0.kind bug report This shouldn't be happening. 1.topic backend This issue relates to the python backend 1.topic frontend 3.skill good first issue good value Solving this issue requires small effort compared to the benefit of closing it
Projects
Couchers Engineering 💻
Status: In Progress
Milestone
Bugs
Development

Successfully merging a pull request may close this issue.

fix empty discussion post in events communities Couchers-org/couchers
8 participants
@aapeliv @schradert @bakeiro @nabramow @lucaslcode @AlexVCS @katemoser @jesseallhands