Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an IndexedMap article (without MultiIndex) #69

Merged
merged 8 commits into from
Jun 27, 2024
Merged

Add an IndexedMap article (without MultiIndex) #69

merged 8 commits into from
Jun 27, 2024

Conversation

uint
Copy link
Contributor

@uint uint commented Jun 24, 2024 •
edited
Loading

1st draft of the IndexedMap article.

TODO in follow-ups:

@vercel Vercel
Copy link

vercel bot commented Jun 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cosmwasm-docs ✅ Ready (Inspect) Visit Preview ✅ 6 resolved Jun 27, 2024 1:45pm

dakom
dakom approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@dakom dakom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few comments, but none of them should block the PR from my perspective :)

src/pages/cw-storage-plus/containers/indexed-map.mdx Show resolved Hide resolved
src/pages/cw-storage-plus/containers/indexed-map.mdx Show resolved Hide resolved
src/pages/cw-storage-plus/containers/indexed-map.mdx Show resolved Hide resolved
src/pages/cw-storage-plus/containers/indexed-map.mdx Show resolved Hide resolved
src/pages/cw-storage-plus/containers/indexed-map.mdx Show resolved Hide resolved
hashedone
hashedone approved these changes Jun 27, 2024
View reviewed changes
Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one! Left some comments on vercel, most of them for you to decide.

@uint uint merged commit 2fe0897 into main Jun 27, 2024
4 checks passed
@uint uint deleted the storage-plus-indexedmap branch June 27, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakom dakom dakom approved these changes

@hashedone hashedone hashedone approved these changes

Assignees
No one assigned
Labels
storage-plus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uint @dakom @hashedone