Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests fail randomly #11

Open
vijairaj opened this issue Aug 29, 2015 · 2 comments
Open

Unit tests fail randomly #11

vijairaj opened this issue Aug 29, 2015 · 2 comments

Comments

@vijairaj
Copy link
Contributor

Unit tests in the folder test fail randomly. On a quick look it seems like the failure is because of using React::MainLoop multiple times and the issue goes away when all the tests are modified to use React::Loop.

@EmielBruijntjes
Copy link
Member

What do you mean with React::MainLoop is used multiple times?

@vijairaj
Copy link
Contributor Author

Many tests today use React::MainLoop, including dns.cpp, read.cpp, thread.cpp, timing.cpp and worker.cpp. So when the test is executed, MainLoop is created and destroyed more than once - I haven't checked if that would be a problem though, but the issue goes away when I replace React::MainLoop with React::Loop in these files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants