Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling the forum index page #86

Open
rgilman opened this issue Nov 6, 2018 · 6 comments
Open

Styling the forum index page #86

rgilman opened this issue Nov 6, 2018 · 6 comments
Assignees

Comments

@rgilman
Copy link
Member

rgilman commented Nov 6, 2018

This is the page that lists the topics in the forum. I've done some work on this page that's in PR #85 .

Before this work, the page looked like this:


screen shot 2018-11-06 at 8 19 48 am

After the work, it looks like this:


screen shot 2018-11-06 at 8 14 21 am

Still to be done: adding tags in with each topic listing and creating a system for filtering – but this can wait for later.

Let me know if you see anything that might be changed at this stage.

@rgilman rgilman self-assigned this Nov 6, 2018
@iangilman
Copy link
Member

Definitely seems to be an improvement!

@wunluv
Copy link
Collaborator

wunluv commented Nov 25, 2018

Certainly feels better! I'm surprised that the "Create New Topic" button was not on the previous version. Useful addition.

If there's no need to repeat the group name, then we could use the first occurrence to indicate our current location within the context of that group - in this example, the forum. If we replace the word "Create" with + it seems to say the same thing with less words.

image10

@rgilman
Copy link
Member Author

rgilman commented Nov 26, 2018

Good point about the repeat of the group name. We need to coordinate what happens on this page with the various other pages in the group's section. I expect that will mean keeping the upper version of the group name. We could just have the large title be "Forum Index" like this:

screen shot 2018-11-25 at 6 21 26 pm

The highlighted menu items in the header provide current location supplemented by the group name and then the page name within the group's section.

I'm neutral on + New Topic. @iangilman and @DavidScottBernstein, thoughts?

@iangilman
Copy link
Member

I like the + ... I think it's a common convention these days.

@rgilman
Copy link
Member Author

rgilman commented Dec 8, 2018

I've made the change to + in the latest push to master.

@iangilman
Copy link
Member

Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants